filter out invalid changeset, before running the action#2249
Merged
zachdaniel merged 3 commits intomainfrom Aug 3, 2025
Merged
filter out invalid changeset, before running the action#2249zachdaniel merged 3 commits intomainfrom
zachdaniel merged 3 commits intomainfrom
Conversation
Contributor
Author
|
@zachdaniel I'm not sure the tests that fail should work. If the changeset is invalid due to incorrect attributes, should the hooks be executed? Because it's not the action failing, but it's failing beforehand. |
zachdaniel
reviewed
Aug 3, 2025
Contributor
|
Hooks should not run on invalid changesets except for after transaction hooks. |
the other hooks are run as part of the action itself and have their own validity checks
zachdaniel
approved these changes
Aug 3, 2025
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.