feat: make enum label/description overridable#2594
Merged
zachdaniel merged 1 commit intoash-project:mainfrom Feb 27, 2026
Merged
feat: make enum label/description overridable#2594zachdaniel merged 1 commit intoash-project:mainfrom
zachdaniel merged 1 commit intoash-project:mainfrom
Conversation
follow-up for ash-project#2172 and ash-project#2222
zachdaniel
approved these changes
Feb 27, 2026
Contributor
|
🚀 Thank you for your contribution! 🚀 |
celeste-wahlquist
pushed a commit
to celeste-wahlquist/ash
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
label/1anddescription/1overridable forAsh.Type.Enum.Also added an example in the docs how to use this to translate labels using Gettext. Maybe this is a bit verbose and hacky (only works if the default locale
msgid==msgstr), but this is what we use it for.This is a follow-up for #2172 and #2222
Contributor checklist
Leave anything that you believe does not apply unchecked.