Skip to content

Add test to verify extra result from pagination is not in after_action callback #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rutgerdj wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

Add test to verify extra result from pagination is not in after_action callback #2607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/page_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
defaults [:read, create: :*]

read :list_objs do
prepare after_action(fn _, results, _ ->
Process.put(:after_action_result_count, length(results))
{:ok, results}
end)

pagination do
keyset? true
offset? true
Expand Down Expand Up @@ -77,8 +82,12 @@
end

describe "offset" do
test "pass", %{ids: ids} do

Check failure on line 85 in test/page_test.exs

View workflow job for this annotation

GitHub Actions / ash-ci (Picosat) / mix test 

test offset pass (Ash.Test.PageTest)

Check failure on line 85 in test/page_test.exs

View workflow job for this annotation

GitHub Actions / ash-ci (SimpleSat) / mix test 

test offset pass (Ash.Test.PageTest)
p1 = ThisTest.Domain.list_objs!(page: [offset: 0])

# Default limit is 3
assert Process.get(:after_action_result_count) == 3

assert %Ash.Page.Offset{results: [_, _, _], more?: true} = p1
assert p1.results |> Enum.map(& &1.id) == Enum.drop(ids, 0) |> Enum.take(3)

Expand Down
Loading