feat: defining tools at the resource level#187
Merged
zachdaniel merged 6 commits intoash-project:mainfrom Apr 22, 2026
Merged
Conversation
zachdaniel
reviewed
Apr 17, 2026
zachdaniel
reviewed
Apr 19, 2026
zachdaniel
reviewed
Apr 19, 2026
zachdaniel
reviewed
Apr 19, 2026
- replace silent Enum.uniq dedupe with explicit duplicate-name validation - raise clear error when domain-level and resource-level tools share a name - set ResourceTools transformer to run after others - detect resource DSL via :spark_is attribute - add tests for duplicate name conflict across domain/resource tools
zachdaniel
approved these changes
Apr 21, 2026
Contributor
Author
|
Hi @zachdaniel I have fixed the spark.formater and cheat_sheet checks in the current PR. I also fixed the open_api_test in #188. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
Summary
Support tools do block on resources directly #171