fix: Makes sure OpenApi schema required list is sorted#190
Merged
zachdaniel merged 1 commit intoash-project:mainfrom Apr 23, 2026
Merged
fix: Makes sure OpenApi schema required list is sorted#190zachdaniel merged 1 commit intoash-project:mainfrom
zachdaniel merged 1 commit intoash-project:mainfrom
Conversation
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very simple PR that basically guarantees that an OpenApi schema is always generated the exact same way if the inputs are the same.
Basically, the required list in the schema is not deterministic, since
Map.keys()doesn't guarantee the order the data will output. This means that, if you call that function with the same input multiple times, there is no guarantee that it will output the list in the exact same order.In my specific use case, this is a big issue because I have a cache system where one of the things I use as the key to the cache, is this schema. and since any required list inside the schema doesn't guarantee order, I was having a bunch of cache misses because of that.
This PR fixes that by sorting the list.
Since it is such a minor change, I didn't change any unit tests, I hope that is OK, but I can create some if needed.
Contributor checklist
Leave anything that you believe does not apply unchecked.