fix: try converting value to existing atom before dumping.#50
Merged
Conversation
zachdaniel
reviewed
Jul 12, 2025
lib/events/action_wrapper_helpers.ex
Outdated
| def dump_value(value, attribute) do | ||
| value = | ||
| if attribute.type == Ash.Type.Atom and is_binary(value), | ||
| do: String.to_existing_atom(value), |
Contributor
There was a problem hiding this comment.
I think this implies a missing step, like of first casting input?
Collaborator
Author
There was a problem hiding this comment.
Yup, agreed!
Updated the code to use cast_input for all values before dumping now.
zachdaniel
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure atom attributes are converted to existing atoms before calling Ash.Type.dump_to_embedded.
When the passed value is a string, this caused an error due to the one_of constraints check failing.