make pagination metadata more robust for offset based pagination#320
Merged
zachdaniel merged 1 commit intoash-project:mainfrom May 29, 2025
Merged
make pagination metadata more robust for offset based pagination#320zachdaniel merged 1 commit intoash-project:mainfrom
zachdaniel merged 1 commit intoash-project:mainfrom
Conversation
xantrac
commented
May 28, 2025
| } | ||
| } | ||
| }, | ||
| %Absinthe.Blueprint.Schema.FieldDefinition{ |
Contributor
Author
There was a problem hiding this comment.
I removed this field definition since it doesn't see be used anywhere
Contributor
There was a problem hiding this comment.
When you say its not used anywhere, wouldn't it have been used by the current type?
It remaps more? to has_next_page. Your current code handles that though so it should be fine to remove.
%Absinthe.Blueprint.Schema.FieldDefinition{
description: "Whether or not there is a next page",
identifier: :has_next_page,
module: schema,
name: "has_next_page",
__reference__: ref(__ENV__),
type: %Absinthe.Blueprint.TypeReference.NonNull{of_type: :boolean}
},
zachdaniel
approved these changes
May 28, 2025
Contributor
|
The compile error here is from a change made to support OTP 28, requires Ash to be upgraded. Does |
Contributor
Author
|
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist