Skip to content

adds simple warning when falling back to jsonstring#368

Merged
zachdaniel merged 1 commit intoash-project:mainfrom
sephianl:add-custom-struct-warning
Dec 31, 2025
Merged

adds simple warning when falling back to jsonstring#368
zachdaniel merged 1 commit intoash-project:mainfrom
sephianl:add-custom-struct-warning

Conversation

@DGollings
Copy link
Copy Markdown
Contributor

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@zachdaniel
Copy link
Copy Markdown
Contributor

I like this, I do worry a bit about an undismissable warning that isn't necessarily a problem though 🤔 Although it's dismissible by defining a new type. Let me think on it for a bit.

@jsw800
Copy link
Copy Markdown
Contributor

jsw800 commented Dec 30, 2025

I really like this, I've accidentally exposed types like this before only for my front end peeps to come asking why this type is janky 😂 but agree about the undismissable thing. I do have one or two types in my own system that I deliberately expose as JsonString. If this could be setup so there's a way to dismiss the warning in that case, that'd be great. I don't know this code well enough to tell if that's currently the case or not

@zachdaniel zachdaniel merged commit 855c99f into ash-project:main Dec 31, 2025
22 checks passed
@zachdaniel
Copy link
Copy Markdown
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants