adds simple warning when falling back to jsonstring#368
Merged
zachdaniel merged 1 commit intoash-project:mainfrom Dec 31, 2025
Merged
adds simple warning when falling back to jsonstring#368zachdaniel merged 1 commit intoash-project:mainfrom
zachdaniel merged 1 commit intoash-project:mainfrom
Conversation
7 tasks
Contributor
|
I like this, I do worry a bit about an undismissable warning that isn't necessarily a problem though 🤔 Although it's dismissible by defining a new type. Let me think on it for a bit. |
Contributor
|
I really like this, I've accidentally exposed types like this before only for my front end peeps to come asking why this type is janky 😂 but agree about the undismissable thing. I do have one or two types in my own system that I deliberately expose as |
zachdaniel
approved these changes
Dec 31, 2025
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.