Fix/ignore nil args in nested pagination#394
Merged
zachdaniel merged 4 commits intoash-project:mainfrom Jan 8, 2026
Merged
Conversation
- Add tracer parameter to Ash.Query.for_read calls in GraphQL resolvers - Enables proper AppSignal tracing for GraphQL operations - Works with Scribble.Telemetry.AppsignalAshGraphql for descriptive span names Closes: AppSignal tracing for GraphQL operations
Add guards in apply_load_arguments: ensure limit/offset are integers, filter is a map, and sort is a list. Add test to confirm nested queries do not raise when limit, offset, filter, or sort variables are nil
zachdaniel
approved these changes
Jan 8, 2026
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
Resolve: #393