Fix/add project specific template support to ash phoenix.gen.live#460
Open
nikfp wants to merge 3 commits intoash-project:mainfrom
Open
Conversation
Author
|
Marked as draft pending #459 - I need to see how that will affect the changes I've made here. |
…e-support-to-ash_phoenix.gen.live
Author
|
After reviewing #459, my changes don't interfere / correlate with that one at all. This is in a working state, please advise on what you would like to see for testing (if any) Since this effectively gives the end user control of the generator output, I'm not sure what to test that would make sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
This PR updated the liveview generators only. I didn't touch the html phoenix generators for now as they don't use the same igniter pattern. Pending approval of this PR and / or related discussion, I might work on the html generators next to update to the igniter pattern.