Merged
Conversation
This was referenced Nov 18, 2025
barnabasJ
force-pushed
the
test/multi-relationship-problems
branch
2 times, most recently
from
76e10e3 to
29db3e6
Compare
zachdaniel
reviewed
Nov 19, 2025
| @@ -0,0 +1,124 @@ | |||
| # SPDX-FileCopyrightText: 2019 ash_postgres contributors <https://github.com/ash-project/ash_postgres/graphs.contributors> | |||
Contributor
There was a problem hiding this comment.
Could we put these tests in like calculations_test.exs for example?
Contributor
|
looks like some conflicts came up. |
Contributor
Author
|
I'll rebase once the other two PRs are released. Then I can also update the
dependencies in one go
…On Fri, 21 Nov 2025, 01:42 Zach Daniel, ***@***.***> wrote:
*zachdaniel* left a comment (ash-project/ash_postgres#654)
<#654 (comment)>
looks like some conflicts came up.
—
Reply to this email directly, view it on GitHub
<#654 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZBCTOZFPZ4AJY54ILBTN335ZNXVAVCNFSM6AAAAACMOJDYUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNRQHAYTEMBTHE>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Contributor
|
Just released |
Contributor
Author
I can't see the ash release. |
barnabasJ
force-pushed
the
test/multi-relationship-problems
branch
from
e0f0055 to
c0df739
Compare
Contributor
|
just released it sorry. |
Contributor
|
Looks like the update pointed out some warnings, mind addressing those here? |
Contributor
Author
sure thing, sorry about that. I just blindly pushed after changing the ash version. |
rgraff
added a commit
that referenced
this pull request
Dec 10, 2025
…tributes * main: (23 commits) fix: do not build query filter with or: [] when all records are successfully inserted, for return_skipped_upsert?: true (#659) test: load aggregate with select and sort on from_many relationship (#661) test: add failing test for expr(has_one.function_calc) nil poisoning in batch (#660) test: aggregate with parent ref in relationship filter and sorting on relationship field (#658) test: binding error when loading aggregate (#657) chore(deps): bump ash_sql in the production-dependencies group (#656) test: multi relationship problems (#654) chore: release version v2.6.26 chore: update ash_sql, use new select binding test: add complex calculation tests with filtered aggregates (#652) improvement: add generator to tsvector type (#655) test: add failing test for aggregate filtering on nested first aggregate (#653) chore: update ash_sql and add test docs: Mention :define_ecto_repo? option of use AshPostgres.Repo macro in getting started guide (#648) improvement: verify check constraint attributes at compile time chore: update ash chore: reuse compliance improvement: update deps for bug fixes chore: release version v2.6.25 test: Add failing test for aggregate with parent() + select() + limit() (#644) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows that there is a problem where both calculations loaded the same value because the read action was not checked when checking if the relationships are the same ash-project/ash#2448
And it shows that the sort on the read action was not taking into account (makes the test flaky) ash-project/ash_sql#194
Contributor checklist
Leave anything that you believe does not apply unchecked.