fix: bulk_create with upsert now updates update_timestamp fields#697
Merged
zachdaniel merged 2 commits intoash-project:mainfrom Feb 20, 2026
Merged
Conversation
…onflict update_timestamp attributes (e.g. updated_at) were never included in the ON CONFLICT DO UPDATE SET clause because they have writable?: false and thus never appear in changeset.attributes. This ensures fields with update_defaults are always included when an upsert modifies fields. Closes ash-project#696
zachdaniel
approved these changes
Feb 20, 2026
Contributor
zachdaniel
left a comment
zachdaniel
left a comment
There was a problem hiding this comment.
I think we should also add this same logic to ash_sqlite. Would you mind opening a similar PR or just an issue to track that? 🙇
Contributor
Author
|
I'll have a look next week. If we implement this for |
Contributor
|
Yeah, I think that would be a great idea 👍. |
Contributor
|
It can set that context automatically, and would work for ETS for example. |
mbaertschi
added a commit
to mbaertschi/ash_sqlite
that referenced
this pull request
Feb 25, 2026
Ports ash-project/ash_postgres#697 to ash_sqlite. update_timestamp attributes (e.g. updated_at) were never included in the ON CONFLICT DO UPDATE SET clause because they have writable?: false. Now fields with update_defaults are always included when an upsert modifies fields. Can be disabled via context: %{data_layer: %{touch_update_defaults?: false}}
7 tasks
zachdaniel
pushed a commit
to ash-project/ash_sqlite
that referenced
this pull request
Feb 25, 2026
Ports ash-project/ash_postgres#697 to ash_sqlite. update_timestamp attributes (e.g. updated_at) were never included in the ON CONFLICT DO UPDATE SET clause because they have writable?: false. Now fields with update_defaults are always included when an upsert modifies fields. Can be disabled via context: %{data_layer: %{touch_update_defaults?: false}}
zachdaniel
pushed a commit
to ash-project/ash_sqlite
that referenced
this pull request
Mar 2, 2026
…geset context (#208) fix: bulk_create with upsert now updates update_timestamp fields Ports ash-project/ash_postgres#697 to ash_sqlite. update_timestamp attributes (e.g. updated_at) were never included in the ON CONFLICT DO UPDATE SET clause because they have writable?: false. Now fields with update_defaults are always included when an upsert modifies fields. Can be disabled via context: %{data_layer: %{touch_update_defaults?: false}}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_timestampattributes (e.g.updated_at) were never included in theON CONFLICT DO UPDATE SETclause because they havewritable?: falseandthus never appear in
changeset.attributes. This ensures fields withupdate_defaultsare always included when an upsert modifies fields.Adds a
touch_update_defaults?data layer context option to opt out of thisbehavior when needed:
Closes #696
Contributor checklist
Leave anything that you believe does not apply unchecked.