fix: exclude :calculations from subquery select in wrap_in_subquery_for_aggregates

[jechol]

When wrap_in_subquery_for_aggregates tries to select :calculations from the subquery, it fails with:

** (Ecto.QueryError) field `calculations` in struct/2 is not available in the subquery. 
Subquery only returns fields: [...]

This fix filters out :calculations from select_calculations, keeping only the actual calculation columns (like __calculations____calc__0).

Contributor checklist

Leave anything that you believe does not apply unchecked.

• I accept the AI Policy, or AI was not used in the creation of this PR.
• Bug fixes include regression tests
• Chores
• Documentation changes
• Features include unit/acceptance tests
• Refactoring
• Update dependencies

[zachdaniel]

Hmm...in the case you're hitting, wouldn't this result in us missing calculations?

[zachdaniel]

What is the value of calculations there when you're hitting that case?

[zachdaniel]

@jechol any update here?

[jechol]

Hi, I just got time to work on this and created a minimal repro: https://github.com/jechol/ash_sql_load_sort_page_bug

Hope this helps with debugging!

[zachdaniel]

Fixed in dc0cdbfd48782858d2d6ce207a57cc3f51cdd3f8

Its very similar to your fix, but it only removes :calculations in the specific case that it is unavailable.

[zachdaniel]

Your reproduction was very helpful, thank you 😄