[proposal] pass through tls_versions to underlying adapter - #50
Merged
Conversation
allow tls_versions ("tlsv1.2", "tlsv1.3") to be set and passed through
to underlying adapter - defaults to "tlsv1.2" - this is to fix middlebox
compatibility mode issues.
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought I'd cut a PR to get some thoughts on this. I'm not sure if I'm thinking about this in the right way. I am running into this when attaching assets (not sure what changed but this was working in the past). I'm using the Backblaze B2 service.
If I understand this correctly, this is caused by the tls middlebox compatibility mode.
This PR allow tls_versions ("tlsv1.2", "tlsv1.3") to be set and passed through to the underlying adapters - defaults to "tlsv1.2". Although, it feels a little strange having to pass in tls versions to the underlying adapter.
It works for me when patched with
tlsv1.2or whenmiddlebox_comp_mode: false-- however,middlebox_comp_modeoption break s3 integration tests and the tests complain that there is a:badargOther relevant information. System is
Contributor checklist
Leave anything that you believe does not apply unchecked.