fix(codegen): generate Array<Record<string, any>> for {:array, :map} return types#56
Merged
Torkan merged 1 commit intoash-project:mainfrom Mar 16, 2026
Merged
Conversation
…return types
Actions returning {:array, :map} were incorrectly generating Record<string, any>
instead of Array<Record<string, any>> in TypeScript. Added :array_of_unconstrained_map
variant following the existing pattern for other array types.
zachdaniel
approved these changes
Mar 6, 2026
Collaborator
|
Sorry for taking so long @barnabasJ! 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{:array, :map}were incorrectly generatingRecord<string, any>instead ofArray<Record<string, any>>in TypeScript:array_of_unconstrained_mapvariant toActionIntrospection, following the existing pattern used for:array_of_typed_map,:array_of_typed_struct, etc.pipeline.ex,function_core.ex, andresult_types.exto handle the new variantTest plan
get_custom_data_listaction returning{:array, :map}Record<string, any>is unchangedcompileGenerated,shouldPass,shouldFail,testZod)mix format,mix credo --strict,mix compile --warnings-as-errorsall pass