Verify Metadata Struct Fields after Compilation#217
Merged
zachdaniel merged 1 commit intoash-project:mainfrom Sep 25, 2025
Merged
Verify Metadata Struct Fields after Compilation#217zachdaniel merged 1 commit intoash-project:mainfrom
zachdaniel merged 1 commit intoash-project:mainfrom
Conversation
zachdaniel
approved these changes
Sep 25, 2025
Contributor
zachdaniel
left a comment
There was a problem hiding this comment.
One thing to note (and I think this was already the case from my impl) is that this doesn't check nested entities (entities inside entities).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
https://discord.com/channels/711271361523351632/1037049265836535868/1420674638622752788
The issue is that the struct module may not be fully compiled when checking and in that case, the
__struct__/0function does not yet exist. Moving the check intoafter_verify.Tests
This does not contain a test. I don't know how I would test this without starting a Parallel Compiler and having a circular dependency. And that would probably mean running a full small fixture mix project.
Contributor checklist
Leave anything that you believe does not apply unchecked.