Fix segmentation fault in TicTacToe minimax due to incorrect board state handling#195
Open
satyajit1288 wants to merge 1 commit into
Open
Fix segmentation fault in TicTacToe minimax due to incorrect board state handling#195satyajit1288 wants to merge 1 commit into
satyajit1288 wants to merge 1 commit into
Conversation
- Passed Board state as parameter to minimax() - Removed dependency on shared Game::board during recursion - Prevented infinite recursion causing stack overflow - Ensured proper simulation of board states during move calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The TicTacToe implementation was causing a segmentation fault during the computer's turn.
Root Cause
The minimax() function was operating on the shared Game::board instead of using simulated board states during recursive evaluation. This caused incorrect recursion behavior and eventual stack overflow.
Solution
Impact