Fix: Makefile build patch not able to recognize tokens and create generated directory if not present #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durwasa-chakraborty
force-pushed
the
WorkingBranch
branch
2 times, most recently
from
c83c291 to
a9aba05
Compare
durwasa-chakraborty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Problem:
Cloning the current project and running the
Makefilebreaks the build because the linker failed to identify the tokens. Additionally, running theStarPlatbinary does not generate thegenerated_backendfolder in{PWD}/graphcode/.Solution:
The following changes address these issues and have been tested locally on both Mac and PopOS variants:
Changes:
parse.traceto ensure proper linking and addedreturn_funcas a token.Request for Review:
@Barenya255, could you double-check this locally and provide some background on the change?