Skip to content

Switch to ureq HTTP client#2

Merged
SamuelSarle merged 2 commits into
asimov-modules:masterfrom
luanlopez:switch-to-ureq
Mar 23, 2026
Merged

Switch to ureq HTTP client#2
SamuelSarle merged 2 commits into
asimov-modules:masterfrom
luanlopez:switch-to-ureq

Conversation

@luanlopez

Copy link
Copy Markdown

Closes #1

Changes

  • Switch from reqwest (async) to ureq (sync) HTTP client
  • Remove tokio dependency, reducing binary size
  • Convert all API methods from async to synchronous
  • Update version to 0.1.5

Testing

All commands tested and working:

  • list-featured-calendars
  • list-categories
  • list-places
  • get-nearby-events
  • asimov-luma-fetcher commands

@isaac-asimov-bot isaac-asimov-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ CI failed

Show all
Platform Name Status Details
All Formatting Details
Linux Build library Details
Linux Build library (no default features) Details
Linux Build binaries Details
Linux Build tests Details
Linux Build examples Details
Linux Run tests Details
Linux Run doctests Details
macOS Build library Details
macOS Build library (no default features) Details
macOS Build binaries Details
macOS Build tests Details
macOS Build examples Details
macOS Run tests Details
macOS Run doctests Details
Windows Build library Details
Windows Build library (no default features) Details
Windows Build binaries Details
Windows Build tests Details
Windows Build examples Details
Windows Run tests Details
Windows Run doctests Details

=============================================

Platform Name Status Details
All Formatting Details

@luanlopez

luanlopez commented Jan 22, 2026

Copy link
Copy Markdown
Author

@imunproductive and @artob I opened this PR to help with improvements, is there a problem?

@luanlopez

Copy link
Copy Markdown
Author

@imunproductive is everthing okay with PR?

@luanlopez

Copy link
Copy Markdown
Author

@SamuelSarle @imunproductive Hi gus, can we merge this PR or should we close it?

@luanlopez

Copy link
Copy Markdown
Author

@SamuelSarle Can I merge this pull request?

@luanlopez

luanlopez commented Mar 23, 2026

Copy link
Copy Markdown
Author

@SamuelSarle I don't have permissions to merge :(

image

@SamuelSarle
SamuelSarle merged commit 4056897 into asimov-modules:master Mar 23, 2026
5 checks passed
@luanlopez
luanlopez deleted the switch-to-ureq branch March 23, 2026 22:04
@SamuelSarle

Copy link
Copy Markdown
Member

@SamuelSarle I don't have permissions to merge :(

image

Ah, sorry. Gave you proper access rights to the repo just now.

@luanlopez

Copy link
Copy Markdown
Author

@SamuelSarle I don't have permissions to merge :(
image

Ah, sorry. Gave you proper access rights to the repo just now.

thank you so much bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to ureq

2 participants