Switch to ureq HTTP client#2
Merged
Merged
Conversation
There was a problem hiding this comment.
⚠️ CI failed
Show all
| Platform | Name | Status | Details |
|---|---|---|---|
| All | Formatting | ❌ | Details |
| Linux | Build library | ✅ | Details |
| Linux | Build library (no default features) | ⏩ | Details |
| Linux | Build binaries | ✅ | Details |
| Linux | Build tests | ✅ | Details |
| Linux | Build examples | ✅ | Details |
| Linux | Run tests | ✅ | Details |
| Linux | Run doctests | ✅ | Details |
| macOS | Build library | ✅ | Details |
| macOS | Build library (no default features) | ⏩ | Details |
| macOS | Build binaries | ✅ | Details |
| macOS | Build tests | ✅ | Details |
| macOS | Build examples | ✅ | Details |
| macOS | Run tests | ✅ | Details |
| macOS | Run doctests | ✅ | Details |
| Windows | Build library | ✅ | Details |
| Windows | Build library (no default features) | ⏩ | Details |
| Windows | Build binaries | ✅ | Details |
| Windows | Build tests | ✅ | Details |
| Windows | Build examples | ✅ | Details |
| Windows | Run tests | ✅ | Details |
| Windows | Run doctests | ✅ | Details |
=============================================
| Platform | Name | Status | Details |
|---|---|---|---|
| All | Formatting | ❌ | Details |
Author
|
@imunproductive and @artob I opened this PR to help with improvements, is there a problem? |
Author
|
@imunproductive is everthing okay with PR? |
Author
|
@SamuelSarle @imunproductive Hi gus, can we merge this PR or should we close it? |
SamuelSarle
approved these changes
Mar 10, 2026
Author
|
@SamuelSarle Can I merge this pull request? |
Author
|
@SamuelSarle I don't have permissions to merge :(
|
Member
Ah, sorry. Gave you proper access rights to the repo just now. |
Author
thank you so much bro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #1
Changes
reqwest(async) toureq(sync) HTTP clienttokiodependency, reducing binary sizeTesting
All commands tested and working:
list-featured-calendarslist-categorieslist-placesget-nearby-eventsasimov-luma-fetchercommands