Set 0o444 file permissions for snapshot files#27
Conversation
|
@SamuelSarle Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 3! @artob received 25 Sloth Points for reviewing and scoring this pull request. Congratulations @SamuelSarle! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
There was a problem hiding this comment.
⚠️ CI failed
Show all
| Platform | Name | Status | Details |
|---|---|---|---|
| All | Formatting | ✅ | Details |
| Linux | Build library | ✅ | Details |
| Linux | Build library (no default features) | ✅ | Details |
| Linux | Build binaries | ✅ | Details |
| Linux | Build tests | ✅ | Details |
| Linux | Build examples | ✅ | Details |
| Linux | Run tests | ✅ | Details |
| Linux | Run doctests | ✅ | Details |
| macOS | Build library | ✅ | Details |
| macOS | Build library (no default features) | ✅ | Details |
| macOS | Build binaries | ✅ | Details |
| macOS | Build tests | ✅ | Details |
| macOS | Build examples | ✅ | Details |
| macOS | Run tests | ✅ | Details |
| macOS | Run doctests | ✅ | Details |
| Windows | Build library | ❌ | Details |
| Windows | Build library (no default features) | ⏩ | Details |
| Windows | Build binaries | ⏩ | Details |
| Windows | Build tests | ⏩ | Details |
| Windows | Build examples | ⏩ | Details |
| Windows | Run tests | ⏩ | Details |
| Windows | Run doctests | ⏩ | Details |
=============================================
| Platform | Name | Status | Details |
|---|---|---|---|
| Windows | Build library | ❌ | Details |
There was a problem hiding this comment.
⚠️ CI failed
Show all
| Platform | Name | Status | Details |
|---|---|---|---|
| All | Formatting | ✅ | Details |
| Linux | Build library | ✅ | Details |
| Linux | Build library (no default features) | ✅ | Details |
| Linux | Build binaries | ✅ | Details |
| Linux | Build tests | ✅ | Details |
| Linux | Build examples | ✅ | Details |
| Linux | Run tests | ✅ | Details |
| Linux | Run doctests | ✅ | Details |
| Windows | Build library | ✅ | Details |
| Windows | Build library (no default features) | ✅ | Details |
| Windows | Build binaries | ✅ | Details |
| Windows | Build tests | ✅ | Details |
| Windows | Build examples | ✅ | Details |
| Windows | Run tests | ❌ | Details |
| Windows | Run doctests | ⏩ | Details |
| macOS | Build library | ✅ | Details |
| macOS | Build library (no default features) | ✅ | Details |
| macOS | Build binaries | ✅ | Details |
| macOS | Build tests | ✅ | Details |
| macOS | Build examples | ✅ | Details |
| macOS | Run tests | ✅ | Details |
| macOS | Run doctests | ✅ | Details |
=============================================
| Platform | Name | Status | Details |
|---|---|---|---|
| Windows | Run tests | ❌ | Details |
There was a problem hiding this comment.
⚠️ CI failed
Show all
| Platform | Name | Status | Details |
|---|---|---|---|
| All | Formatting | ✅ | Details |
| macOS | Build library | ✅ | Details |
| macOS | Build library (no default features) | ✅ | Details |
| macOS | Build binaries | ✅ | Details |
| macOS | Build tests | ✅ | Details |
| macOS | Build examples | ✅ | Details |
| macOS | Run tests | ✅ | Details |
| macOS | Run doctests | ✅ | Details |
| Linux | Build library | ✅ | Details |
| Linux | Build library (no default features) | ✅ | Details |
| Linux | Build binaries | ✅ | Details |
| Linux | Build tests | ✅ | Details |
| Linux | Build examples | ✅ | Details |
| Linux | Run tests | ✅ | Details |
| Linux | Run doctests | ✅ | Details |
| Windows | Build library | ✅ | Details |
| Windows | Build library (no default features) | ✅ | Details |
| Windows | Build binaries | ✅ | Details |
| Windows | Build tests | ✅ | Details |
| Windows | Build examples | ✅ | Details |
| Windows | Run tests | ❌ | Details |
| Windows | Run doctests | ⏩ | Details |
=============================================
| Platform | Name | Status | Details |
|---|---|---|---|
| Windows | Run tests | ❌ | Details |
There was a problem hiding this comment.
⚠️ CI failed
Show all
| Platform | Name | Status | Details |
|---|---|---|---|
| All | Formatting | ✅ | Details |
| Linux | Build library | ✅ | Details |
| Linux | Build library (no default features) | ✅ | Details |
| Linux | Build binaries | ✅ | Details |
| Linux | Build tests | ✅ | Details |
| Linux | Build examples | ✅ | Details |
| Linux | Run tests | ✅ | Details |
| Linux | Run doctests | ✅ | Details |
| Windows | Build library | ✅ | Details |
| Windows | Build library (no default features) | ✅ | Details |
| Windows | Build binaries | ✅ | Details |
| Windows | Build tests | ✅ | Details |
| Windows | Build examples | ✅ | Details |
| Windows | Run tests | ❌ | Details |
| Windows | Run doctests | ⏩ | Details |
| macOS | Build library | ✅ | Details |
| macOS | Build library (no default features) | ✅ | Details |
| macOS | Build binaries | ✅ | Details |
| macOS | Build tests | ✅ | Details |
| macOS | Build examples | ✅ | Details |
| macOS | Run tests | ✅ | Details |
| macOS | Run doctests | ✅ | Details |
=============================================
| Platform | Name | Status | Details |
|---|---|---|---|
| Windows | Run tests | ❌ | Details |
There was a problem hiding this comment.
⚠️ CI failed
Show all
| Platform | Name | Status | Details |
|---|---|---|---|
| All | Formatting | ✅ | Details |
| macOS | Build library | ✅ | Details |
| macOS | Build library (no default features) | ✅ | Details |
| macOS | Build binaries | ✅ | Details |
| macOS | Build tests | ✅ | Details |
| macOS | Build examples | ✅ | Details |
| macOS | Run tests | ✅ | Details |
| macOS | Run doctests | ✅ | Details |
| Linux | Build library | ✅ | Details |
| Linux | Build library (no default features) | ✅ | Details |
| Linux | Build binaries | ✅ | Details |
| Linux | Build tests | ✅ | Details |
| Linux | Build examples | ✅ | Details |
| Linux | Run tests | ✅ | Details |
| Linux | Run doctests | ✅ | Details |
| Windows | Build library | ✅ | Details |
| Windows | Build library (no default features) | ✅ | Details |
| Windows | Build binaries | ✅ | Details |
| Windows | Build tests | ✅ | Details |
| Windows | Build examples | ✅ | Details |
| Windows | Run tests | ❌ | Details |
| Windows | Run doctests | ⏩ | Details |
=============================================
| Platform | Name | Status | Details |
|---|---|---|---|
| Windows | Run tests | ❌ | Details |
There was a problem hiding this comment.
Pull Request Overview
This PR implements setting read-only file permissions (0o444) for snapshot files and URL metadata files to prevent accidental modification. It also improves cross-platform compatibility by adding Windows-specific logic to handle read-only file deletion.
- Replaces simple file writes with explicit file creation and permission setting
- Adds Windows-compatible file deletion logic that handles read-only files
- Refactors test code to use
unwrap()instead of returningResult<()>
|
🥁 Score it! @artob, please score the PR with |
|
@race-of-sloths score 3 |
Resolves asimov-platform/asimov-snapshot-cli#9
@race-of-sloths