Skip to content

feat: add specifications section#11

Merged
artob merged 1 commit into
masterfrom
feat/add-specification-section
Jun 23, 2025
Merged

feat: add specifications section#11
artob merged 1 commit into
masterfrom
feat/add-specification-section

Conversation

@shelegdmitriy

Copy link
Copy Markdown
Collaborator

This pull request introduces a new "Asimov Specifications" section to the application, updates navigation and footer links to include the specifications, and adds supporting configuration for URLs. Below is a breakdown of the most important changes grouped by theme.

Addition of "Asimov Specifications" Section

  • Added a new AsimovSpecifications.svelte component that includes a detailed layout for the specifications section, animations, and links to view the specification and contribute via GitHub. (src/components/sections/AsimovSpecifications.svelte)
  • Imported the AsimovSpecifications component in App.svelte and added it to the main content area. (src/App.svelte) [1] [2]

Navigation Updates

  • Updated the NavBar.svelte component to include a "Docs" navigation item pointing to the specifications section. (src/components/common/NavBar.svelte)

URL Configuration Updates

  • Replaced the docsUrl configuration with modulesSpecsUrl and modulesSpecsGithubUrl for linking to the specifications page and its GitHub repository. (src/lib/config.ts)
  • Updated the footer links to use the new modulesSpecsUrl for the documentation link. (src/lib/config.ts)

@shelegdmitriy shelegdmitriy requested a review from Copilot June 20, 2025 12:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new "Asimov Specifications" section to the application, updates navigation to include a direct link to the specifications, and revises URL configuration for documentation links.

  • Introduces a new Svelte component (AsimovSpecifications.svelte) with entry animations and external links.
  • Updates config.ts by replacing docsUrl with modulesSpecsUrl and modulesSpecsGithubUrl.
  • Adds a "Docs" nav item in NavBar.svelte and integrates the new specifications component in App.svelte.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
src/lib/config.ts Replaced docsUrl with modulesSpecsUrl and updated footer documentation link.
src/components/sections/AsimovSpecifications.svelte New component with animations and external links for the specifications section.
src/components/common/NavBar.svelte Added a "Docs" nav item linking to the specifications section.
src/App.svelte Imported and rendered the new AsimovSpecifications component.
Comments suppressed due to low confidence (1)

src/lib/config.ts:6

  • [nitpick] Consider verifying if the removal of the trailing slash from the URL is intentional and consistent with how the URL is used elsewhere.
export const modulesSpecsUrl = 'https://asimov-specs.github.io';

@shelegdmitriy

Copy link
Copy Markdown
Collaborator Author

@artob are you good with how this section looks?

Знімок екрана 2025-06-20 о 14 48 30

@shelegdmitriy shelegdmitriy requested a review from artob June 20, 2025 12:49
@artob artob self-assigned this Jun 23, 2025
@artob artob added the enhancement New feature or request label Jun 23, 2025
@artob

artob commented Jun 23, 2025

Copy link
Copy Markdown
Member

@race-of-sloths score 5

@artob artob merged commit 31f62af into master Jun 23, 2025
1 check passed
@artob artob deleted the feat/add-specification-section branch June 23, 2025 16:03
@race-of-sloths

race-of-sloths commented Jun 23, 2025

Copy link
Copy Markdown

@shelegdmitriy Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@artob 5

Your contribution is much appreciated with a final score of 5!
You have received 65 (50 base + 15 weekly bonus) Sloth points for this contribution

@artob received 25 Sloth Points for reviewing and scoring this pull request.

Another weekly streak completed, well done @shelegdmitriy! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants