Skip to content

chore: upload logo#14

Merged
shelegdmitriy merged 1 commit into
masterfrom
chore/add-logo
Jun 10, 2025
Merged

chore: upload logo#14
shelegdmitriy merged 1 commit into
masterfrom
chore/add-logo

Conversation

@shelegdmitriy

Copy link
Copy Markdown
Member

This pull request introduces updates to the favicon, a new logo component, and its integration into the navigation bar. The changes enhance the visual design and branding of the application.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a scalable SVG logo component, integrates it into the site’s navbar, and switches the favicon from PNG to SVG to improve branding consistency.

  • Swaps out the PNG favicon for an SVG version
  • Introduces a reusable Logo.svelte component
  • Imports and embeds the logo into Navbar.svelte

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/app.html Updated <link rel="icon"> to use SVG
src/components/Logo.svelte New SVG logo component with hover styling
src/components/Navbar.svelte Imported Logo and replaced text branding
Comments suppressed due to low confidence (3)

src/components/Logo.svelte:2

  • [nitpick] The prop name style can be misleading since it’s used to pass CSS classes; consider renaming it to className or classes.
  let { style } = $props();

src/components/Navbar.svelte:62

  • [nitpick] Passing Tailwind classes via a style prop is confusing; after renaming the prop (e.g. to className), use <Logo className="w-50" /> or leverage Svelte’s class: directives.
<Logo style="w-50" />

src/components/Logo.svelte:5

  • The <svg> is missing accessibility attributes; consider adding role="img" and either a <title> element or aria-label to describe the logo for screen readers.
<svg width="1026" height="179" ...>

Comment thread src/components/Logo.svelte Outdated
@shelegdmitriy
shelegdmitriy merged commit 17228c7 into master Jun 10, 2025
1 check passed
@shelegdmitriy
shelegdmitriy deleted the chore/add-logo branch June 10, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants