chore: update metrics badge component#35
Merged
Conversation
shelegdmitriy
temporarily deployed
to
chore/update-metrics-badge-component - asimov.directory PR #35
November 11, 2025 21:57 — with 
Render
Destroyed
Render
Destroyed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the MetricsBadge component to enhance type safety, streamline default behavior, and improve the loading state presentation with a more polished skeleton UI.
Key changes:
- Switched icon type from generic React component type to the stricter
Icontype from@phosphor-icons/react - Added default values for
variant('desktop') andloading(false) props - Refactored loading UI with early return pattern and improved skeleton design featuring animated placeholders
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
MetricsBadgecomponent to improve its type safety, default props, and loading state display. The most important changes are grouped below:Type improvements:
iconprop type to use theIcontype from@phosphor-icons/reactfor better type safety and consistency.Props and default values:
variantandloadingprops ('desktop'andfalse, respectively) to simplify usage and prevent undefined behavior.Loading state UI: