Fix Codex marketplace credential cleanup gate - #29
Merged
Merged
Conversation
Contributor
Author
|
Delivered to Main CI passed: https://github.com/askgina/plugins/actions/runs/33017864779 The immutable-revision |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugin removeandmarketplace removewhen credentials remain in the isolated HOMEmarketplace-addcan run and scoped temporary state still disappearsVerification
bun --bun node_modules/.bin/vp test --run packages/evals/__tests__/check-codex-marketplace.test.ts— 1 file, 7 testsbun run checkbun run test— 15 files, 134 testsbun run effect-tsgo:diagnostics— 62 files, 0 diagnosticsbun audit— 320 packages, 0 vulnerabilitiesbun run check:public-boundarywith Node 24.18.0 — 270 files, 11 archives, 0 findingsContext
Forward fix for the post-merge credential-lifetime finding on #28. The trusted
marketplace-addprocess remains the only child allowed to receiveGIT_ASKPASS; all subsequent normal and cleanup commands require successful deletion and absence verification first.