fix(devin): stage the manifest logo asset in the Devin target - #76
Merged
Conversation
The Devin manifest now points logo at assets/icon.svg, but the generated Devin tree and archive carried only .devin-plugin, .mcp.json, and skills/. Stage exactly that file alongside .mcp.json in both the sync target and the artifact stage, treat assets as a native Devin surface, and add a devin.assets.icon_exists conformance check so the extracted archive proves every manifest-relative asset is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#75 added
logo: "assets/icon.svg"to.devin-plugin/plugin.json, but the generated Devin target anddist/targets/ask-gina-devin-<version>.tgzcontain only.devin-plugin/,.mcp.json, andskills/, so the archive referenced a file it did not carry.What
tools/pack-artifacts.ts,tools/sync-plugin-skills.ts: stageassets/icon.svg(the single manifest-referenced asset) next to.mcp.jsonin the Devin target.tools/check-target-conformance.ts:assetsis no longer a foreign artifact for Devin; newdevin.assets.icon_existscheck runs on the generated target and, viaverify-artifacts, on the extracted archive..devin-plugin,.mcp.json,assets/icon.svg,skills/with byte-identical copies.ai_docs/architecture.md: layout sentence updated.Proof (local, narrow)
bunx vitest run plugins/ask-gina/__tests__/sync-plugin-skills.test.ts tools/__tests__/pack-artifacts.test.ts: 18/18.bun tools/check-target-conformance.ts: 231/231 (was 230/231 before the foreign-artifact fix caught the new surface).Archive build + extraction proof is CI's (
verify-artifacts).Follow-up
CognitionAI/devin-marketplace#14 will be bumped to this PR's merge commit.