feat: change baseDir for local file path accessing#350
Open
nttg8100 wants to merge 3 commits intoaskimed:mainfrom
Open
feat: change baseDir for local file path accessing#350nttg8100 wants to merge 3 commits intoaskimed:mainfrom
nttg8100 wants to merge 3 commits intoaskimed:mainfrom
Conversation
Author
|
Hi @nvnieuwk , I found that previously the tests were failed. The issue was not from the new feature on my PR. Can you trigger the tests again ? |
Collaborator
|
Hi, the failures are caused by the change you implemented. I'm not too familiar with this part of the codebase myself so I can't judge if this is the better way. Maybe @lukfor can give you some more pointers? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issues on #222 and #273: