Update outdated plugin JSON files automatically when a plugin version is not available#356
Merged
nvnieuwk merged 1 commit intoaskimed:mainfrom Mar 17, 2026
Merged
Conversation
lukfor
requested changes
Mar 17, 2026
Collaborator
lukfor
left a comment
lukfor
left a comment
There was a problem hiding this comment.
perfect! this helps a lot
lukfor
approved these changes
Mar 17, 2026
Collaborator
Author
|
Thank you for the quick review!! |
Collaborator
You work like a machine Nicolas!! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the PluginRepository code to automatically download the latest plugins JSON files whenever a version or plugin is missing from the cached file. Due to this change people won't have to run
nf-test update-pluginsanymore when updating plugin versions in the config.I tested the following cases:
An existing plugin is missing from the JSON
=> The JSON file gets pulled again and finds the plugin in it, tests start like expected
An existing version of a plugin is missing from the JSON
=> Same outcome as the last case
An unknown plugin is specified
=> The cache gets updated but the tests won't start and throw this error:
Plugin'nft-unknown' not found.A non-existing version is specified
=> The cache gets updated but the tests won't start and throw this error:
Plugin'nft-bam' found, but version 0.9.0 not found.