Codecvt c++17 - #326
Merged
Merged
Conversation
Owner
|
Could you please rebase this onto master? |
meynardc
force-pushed
the
codecvt_c++17
branch
from
October 24, 2025 14:10
7566675 to
bd8238a
Compare
Contributor
Author
|
Rebased ... |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We use libE57Format in a stdc++17 project (https://github.com/micmacIGN/micmac/tree/master/MMVII)
Sadly, the codecvt_utf8_utf16(...) function is deprecated since C++17 and removed in C++26.
I propose a replacement using the windows native function MultiByteToWideChar() (only if compiling on Windows and only if C++ version is >= 17).
To test it, in CMakeLists.txt set :
target_compile_features( ${PROJECT_NAME} PRIVATE cxx_std_14 )to cxx_std_17 or cxx_std_20.
(This PR follows my previous PR #325, making Windows CI working again)