feat: expand audit mode with config health checks and tests#1
Merged
Conversation
Add three new AuditFetchers that flag alert configuration issues: - disabled_conditions: NRQL conditions with enabled=false - uncovered_alert_policies: policies with active conditions but no aiWorkflow routing their alerts, and policies with zero conditions - legacy_conditions: APM/Browser/Mobile metric conditions that should be migrated to NRQL Update report.go to render config findings (empty IDType) without the ID->entity resolution line, and split the overall summary into "Hardcoded ID refs" and "Config issues" counters. Fix resolver.go suggest() to preserve pre-set Suggestion on config findings instead of overwriting with an empty string. Add 8 test files covering patterns, CSV, report, and all four fetchers (conditions, disabled, uncovered policies, legacy). Update CI to emit a coverage report and upload coverage.out as an artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three new AuditFetchers that flag alert configuration issues:
Update report.go to render config findings (empty IDType) without the ID->entity resolution line, and split the overall summary into "Hardcoded ID refs" and "Config issues" counters.
Fix resolver.go suggest() to preserve pre-set Suggestion on config findings instead of overwriting with an empty string.
Add 8 test files covering patterns, CSV, report, and all four fetchers (conditions, disabled, uncovered policies, legacy). Update CI to emit a coverage report and upload coverage.out as an artifact.