Skip to content

Commit f0c9856

Browse files
jbedardjbedard
committed
remove name = "node_modules"
1 parent c0055f9 commit f0c9856

File tree

60 files changed

+58
-60
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+58
-60
lines changed

‎e2e/bzlmod/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ not_windows = select({
1212
})
1313

1414
npm_link_all_packages(
15-
name = "node_modules",
1615
imported_links = [
1716
npm_link_meaning_of_life,
1817
],

‎e2e/bzlmod/other_module/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@npm_other_module//:defs.bzl", "npm_link_all_packages")
22
load("@npm_other_module//:pyright/package_json.bzl", pyright = "bin")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
pyright.pyright_binary(
77
name = "pyright",

‎e2e/gyp_no_install_script/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_files")
22
load("@aspect_rules_js//js:defs.bzl", "js_test")
33
load("@npm//:defs.bzl", "npm_link_all_packages")
44

5-
npm_link_all_packages(name = "node_modules")
5+
npm_link_all_packages()
66

77
js_test(
88
name = "test",

‎e2e/js_image_docker/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ load("@io_bazel_rules_docker//container:layer.bzl", "container_layer")
66
load("@io_bazel_rules_docker//contrib:test.bzl", "container_test")
77
load("@npm//:defs.bzl", "npm_link_all_packages")
88

9-
npm_link_all_packages(name = "node_modules")
9+
npm_link_all_packages()
1010

1111
platform(
1212
name = "arm64_linux",

‎e2e/js_image_oci/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
load("@npm//:defs.bzl", "npm_link_all_packages")
22

3-
npm_link_all_packages(name = "node_modules")
3+
npm_link_all_packages()

‎e2e/js_image_oci/pkg/a/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@aspect_rules_js//npm:defs.bzl", "npm_package")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
npm_package(
77
name = "pkg",

‎e2e/js_image_oci/pkg/b/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@aspect_rules_js//js:defs.bzl", "js_library")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
js_library(
77
name = "pkg",

‎e2e/js_run_devserver/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@bazel_skylib//rules:build_test.bzl", "build_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
build_test(
77
name = "test",

‎e2e/npm_link_package-esm/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("@bazel_skylib//rules:build_test.bzl", "build_test")
44
load("@foo//:@aspect-test/a/package_json.bzl", aspect_test_a_bin = "bin")
55
load("@npm//:defs.bzl", "npm_link_all_packages")
66

7-
npm_link_all_packages(name = "node_modules")
7+
npm_link_all_packages()
88

99
npm_link_package(
1010
name = "node_modules/@e2e/lib",

‎e2e/npm_link_package-rerooted/root/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("@bazel_skylib//rules:build_test.bzl", "build_test")
44
load("@foo//:@aspect-test/a/package_json.bzl", aspect_test_a_bin = "bin")
55
load("@npm//:defs.bzl", "npm_link_all_packages")
66

7-
npm_link_all_packages(name = "node_modules")
7+
npm_link_all_packages()
88

99
npm_link_package(
1010
name = "node_modules/@e2e/lib",

‎e2e/npm_link_package/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("@bazel_skylib//rules:build_test.bzl", "build_test")
44
load("@foo//:@aspect-test/a/package_json.bzl", aspect_test_a_bin = "bin")
55
load("@npm//:defs.bzl", "npm_link_all_packages")
66

7-
npm_link_all_packages(name = "node_modules")
7+
npm_link_all_packages()
88

99
npm_link_package(
1010
name = "node_modules/@e2e/lib",

‎e2e/npm_translate_lock/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_files")
22
load("@bazel_skylib//rules:build_test.bzl", "build_test")
33
load("@npm//:defs.bzl", "npm_link_all_packages")
44

5-
npm_link_all_packages(name = "node_modules")
5+
npm_link_all_packages()
66

77
build_test(
88
name = "test",

‎e2e/npm_translate_lock_auth/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@bazel_skylib//rules:build_test.bzl", "build_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
build_test(
77
name = "test",

‎e2e/npm_translate_lock_disable_hooks/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_files")
22
load("@bazel_skylib//rules:build_test.bzl", "build_test")
33
load("@npm//:defs.bzl", "npm_link_all_packages")
44

5-
npm_link_all_packages(name = "node_modules")
5+
npm_link_all_packages()
66

77
build_test(
88
name = "test",

‎e2e/npm_translate_lock_empty/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_files")
22
load("@bazel_skylib//rules:build_test.bzl", "build_test")
33
load("@npm//:defs.bzl", "npm_link_all_packages")
44

5-
npm_link_all_packages(name = "node_modules")
5+
npm_link_all_packages()
66

77
build_test(
88
name = "test",

‎e2e/npm_translate_lock_exclude_package_contents/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
load("@npm//:defs.bzl", "npm_link_all_packages")
22

3-
npm_link_all_packages(name = "node_modules")
3+
npm_link_all_packages()
44

55
sh_test(
66
name = "test_sh",

‎e2e/npm_translate_lock_git+ssh/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@bazel_skylib//rules:build_test.bzl", "build_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
build_test(
77
name = "test",

‎e2e/npm_translate_lock_partial_clone/root/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@bazel_skylib//rules:build_test.bzl", "build_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
build_test(
77
name = "test",

‎e2e/npm_translate_lock_replace_packages/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("@aspect_rules_js//npm:defs.bzl", "npm_package")
44
load("@bazel_skylib//rules:build_test.bzl", "build_test")
55
load("@npm//:defs.bzl", "npm_link_all_packages")
66

7-
npm_link_all_packages(name = "node_modules")
7+
npm_link_all_packages()
88

99
js_test(
1010
name = "test",

‎e2e/npm_translate_lock_subdir_patch/subdir/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@aspect_rules_js//js:defs.bzl", "js_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
js_test(
77
name = "test",

‎e2e/npm_translate_package_lock/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@bazel_skylib//rules:build_test.bzl", "build_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
build_test(
77
name = "test",

‎e2e/npm_translate_yarn_lock/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@bazel_skylib//rules:build_test.bzl", "build_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
build_test(
77
name = "test",

‎e2e/package_json_module/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@npm//:defs.bzl", "npm_link_all_packages")
22
load("@npm//:mocha/package_json.bzl", mocha_bin = "bin")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
mocha_bin.mocha_test(
77
name = "test",

‎e2e/patch_from_repo/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@bazel_skylib//rules:build_test.bzl", "build_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
build_test(
77
name = "test",

‎e2e/pnpm_workspace/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_files")
44
load("@bazel_skylib//rules:build_test.bzl", "build_test")
55
load("@npm//:defs.bzl", "npm_link_all_packages")
66

7-
npm_link_all_packages(name = "node_modules")
7+
npm_link_all_packages()
88

99
sh_test(
1010
name = "node_test",

‎e2e/pnpm_workspace/app/a/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("@bazel_skylib//rules:build_test.bzl", "build_test")
44
load("@npm//:defs.bzl", "npm_link_all_packages", "npm_link_targets")
55
load("@npm//app/a:@aspect-test/a/package_json.bzl", aspect_test_a_bin = "bin")
66

7-
npm_link_all_packages(name = "node_modules")
7+
npm_link_all_packages()
88

99
js_binary(
1010
name = "main",

‎e2e/pnpm_workspace/app/b/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("@aspect_rules_js//js:defs.bzl", "js_binary", "js_test")
44
load("@bazel_skylib//rules:build_test.bzl", "build_test")
55
load("@npm//:defs.bzl", "npm_link_all_packages")
66

7-
npm_link_all_packages(name = "node_modules")
7+
npm_link_all_packages()
88

99
js_binary(
1010
name = "main",

‎e2e/pnpm_workspace/app/c/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ load("@aspect_rules_js//js:defs.bzl", "js_binary", "js_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33
load("@npm//app/a:@aspect-test/a/package_json.bzl", aspect_test_a_bin = "bin")
44

5-
npm_link_all_packages(name = "node_modules")
5+
npm_link_all_packages()
66

77
js_binary(
88
name = "main",

‎e2e/pnpm_workspace/app/d/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@aspect_rules_js//js:defs.bzl", "js_binary", "js_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
js_binary(
77
name = "main",

‎e2e/pnpm_workspace/lib/a/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("@aspect_rules_js//npm:defs.bzl", "npm_package")
44
load("@bazel_skylib//rules:build_test.bzl", "build_test")
55
load("@npm//:defs.bzl", "npm_link_all_packages")
66

7-
npm_link_all_packages(name = "node_modules")
7+
npm_link_all_packages()
88

99
npm_package(
1010
name = "pkg",

‎e2e/pnpm_workspace/lib/b/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ load("@aspect_rules_js//npm:defs.bzl", "npm_package")
22
load("@bazel_skylib//rules:build_test.bzl", "build_test")
33
load("@npm//:defs.bzl", "npm_link_all_packages")
44

5-
npm_link_all_packages(name = "node_modules")
5+
npm_link_all_packages()
66

77
npm_package(
88
name = "pkg",

‎e2e/pnpm_workspace/lib/c/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
load("@aspect_rules_js//npm:defs.bzl", "npm_package")
44
load("@npm//:defs.bzl", "npm_link_all_packages")
55

6-
npm_link_all_packages(name = "node_modules")
6+
npm_link_all_packages()
77

88
npm_package(
99
name = "pkg",

‎e2e/pnpm_workspace/lib/d/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ load("@aspect_rules_js//js:defs.bzl", "js_library")
22
load("@bazel_skylib//rules:build_test.bzl", "build_test")
33
load("@npm//:defs.bzl", "npm_link_all_packages")
44

5-
npm_link_all_packages(name = "node_modules")
5+
npm_link_all_packages()
66

77
js_library(
88
name = "pkg",

‎e2e/pnpm_workspace_deps/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
load("@npm//:defs.bzl", "npm_link_all_packages")
22

3-
npm_link_all_packages(name = "node_modules")
3+
npm_link_all_packages()

‎e2e/pnpm_workspace_deps/lib-dupes/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ load("@aspect_rules_js//js:defs.bzl", "js_library")
22
load("@aspect_rules_js//npm:defs.bzl", "npm_package")
33
load("@npm//:defs.bzl", "npm_link_all_packages")
44

5-
npm_link_all_packages(name = "node_modules")
5+
npm_link_all_packages()
66

77
# A library with 2 aliases to one simple dependency (package with no dependencies)
88
js_library(

‎e2e/pnpm_workspace_deps/lib/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ load("@aspect_rules_js//js:defs.bzl", "js_library")
22
load("@aspect_rules_js//npm:defs.bzl", "npm_package")
33
load("@npm//:defs.bzl", "npm_link_all_packages")
44

5-
npm_link_all_packages(name = "node_modules")
5+
npm_link_all_packages()
66

77
# A basic library with 2 simple dependencies (packages with no dependencies))
88
js_library(

‎e2e/pnpm_workspace_deps/tests/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@aspect_rules_js//js:defs.bzl", "js_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
# Exposed by js_library()
77
js_test(

‎e2e/pnpm_workspace_rerooted/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_files")
44
load("@bazel_skylib//rules:build_test.bzl", "build_test")
55
load("@npm//:defs.bzl", "npm_link_all_packages")
66

7-
npm_link_all_packages(name = "node_modules")
7+
npm_link_all_packages()
88

99
sh_test(
1010
name = "node_test",

‎e2e/pnpm_workspace_rerooted/app/a/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("@bazel_skylib//rules:build_test.bzl", "build_test")
44
load("@npm//:defs.bzl", "npm_link_all_packages", "npm_link_targets")
55
load("@npm//app/a:@aspect-test/a/package_json.bzl", aspect_test_a_bin = "bin")
66

7-
npm_link_all_packages(name = "node_modules")
7+
npm_link_all_packages()
88

99
js_binary(
1010
name = "main",

‎e2e/pnpm_workspace_rerooted/app/b/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("@aspect_rules_js//js:defs.bzl", "js_binary", "js_test")
44
load("@bazel_skylib//rules:build_test.bzl", "build_test")
55
load("@npm//:defs.bzl", "npm_link_all_packages")
66

7-
npm_link_all_packages(name = "node_modules")
7+
npm_link_all_packages()
88

99
js_binary(
1010
name = "main",

‎e2e/pnpm_workspace_rerooted/app/c/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ load("@aspect_rules_js//js:defs.bzl", "js_binary", "js_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33
load("@npm//app/a:@aspect-test/a/package_json.bzl", aspect_test_a_bin = "bin")
44

5-
npm_link_all_packages(name = "node_modules")
5+
npm_link_all_packages()
66

77
js_binary(
88
name = "main",

‎e2e/pnpm_workspace_rerooted/app/d/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
load("@aspect_rules_js//js:defs.bzl", "js_binary", "js_test")
22
load("@npm//:defs.bzl", "npm_link_all_packages")
33

4-
npm_link_all_packages(name = "node_modules")
4+
npm_link_all_packages()
55

66
js_binary(
77
name = "main",

‎e2e/pnpm_workspace_rerooted/lib/a/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("@aspect_rules_js//npm:defs.bzl", "npm_package")
44
load("@bazel_skylib//rules:build_test.bzl", "build_test")
55
load("@npm//:defs.bzl", "npm_link_all_packages")
66

7-
npm_link_all_packages(name = "node_modules")
7+
npm_link_all_packages()
88

99
npm_package(
1010
name = "pkg",

‎e2e/pnpm_workspace_rerooted/lib/b/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ load("@aspect_rules_js//npm:defs.bzl", "npm_package")
22
load("@bazel_skylib//rules:build_test.bzl", "build_test")
33
load("@npm//:defs.bzl", "npm_link_all_packages")
44

5-
npm_link_all_packages(name = "node_modules")
5+
npm_link_all_packages()
66

77
npm_package(
88
name = "pkg",

‎e2e/pnpm_workspace_rerooted/lib/c/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
load("@aspect_rules_js//npm:defs.bzl", "npm_package")
44
load("@npm//:defs.bzl", "npm_link_all_packages")
55

6-
npm_link_all_packages(name = "node_modules")
6+
npm_link_all_packages()
77

88
npm_package(
99
name = "pkg",

0 commit comments

Comments
 (0)