WIP: Add an option to bundle NPM packages while installing#1422
Open
DavidZbarsky-at wants to merge 1 commit intoaspect-build:2.xfrom
Open
WIP: Add an option to bundle NPM packages while installing#1422DavidZbarsky-at wants to merge 1 commit intoaspect-build:2.xfrom
DavidZbarsky-at wants to merge 1 commit intoaspect-build:2.xfrom
Conversation
|
|
DavidZbarsky-at
force-pushed
the
zbarsky/optimize-packages
branch
2 times, most recently
from
ad173e9 to
3278d9b
Compare
DavidZbarsky-at
commented
Jan 1, 2024
npm/private/npm_import.bzl
Outdated
| rules_js_metadata = {} | ||
|
|
||
| custom_postinstalls = rctx.attr.custom_postinstall | ||
| if rctx.attr.package.startswith("@aws-sdk/client"): |
Contributor
Author
There was a problem hiding this comment.
this was a hack, really we should check if custom_postinstalls == ["optimize_package"] or something
DavidZbarsky-at
force-pushed
the
zbarsky/optimize-packages
branch
2 times, most recently
from
3c41584 to
07b224b
Compare
DavidZbarsky-at
force-pushed
the
zbarsky/optimize-packages
branch
2 times, most recently
from
2201a26 to
9831ce2
Compare
DavidZbarsky-at
force-pushed
the
zbarsky/optimize-packages
branch
from
9831ce2 to
6065fb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would have preferred to bundle with esbuild, but esbuild itself cannot be bundled, it must be marked external. (I even tried with esbuild-wasm). So that would complicate the setup a little bit.