Skip to content

feat: support pnpm v10 #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: support pnpm v10 #2101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions e2e/pnpm_lockfiles/.bazelignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@ v54/node_modules/
v60/node_modules/
v61/node_modules/
v90/node_modules/
v10/node_modules/
vendored/is-number/node_modules
1 change: 1 addition & 0 deletions e2e/pnpm_lockfiles/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ PNPM_LOCK_VERSIONS = [
"v60",
"v61",
"v90",
"v10",
]

# Lockfiles with unique test cases
Expand Down
4 changes: 4 additions & 0 deletions e2e/pnpm_lockfiles/WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ PNPM_LOCK_VERSIONS = [
"v60",
"v61",
"v90",
"v10",
]

# Lockfiles with unique test cases
Expand Down Expand Up @@ -44,6 +45,7 @@ load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")
for version in PNPM_LOCK_VERSIONS
]

load("@lock-v10//:repositories.bzl", npm_repositories_v10 = "npm_repositories")
load("@lock-v54//:repositories.bzl", npm_repositories_v54 = "npm_repositories")
load("@lock-v60//:repositories.bzl", npm_repositories_v60 = "npm_repositories")
load("@lock-v61//:repositories.bzl", npm_repositories_v61 = "npm_repositories")
Expand All @@ -57,6 +59,8 @@ npm_repositories_v61()

npm_repositories_v90()

npm_repositories_v10()

[
npm_translate_lock(
name = lockfile.replace(".yaml", ""),
Expand Down
3 changes: 3 additions & 0 deletions e2e/pnpm_lockfiles/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,6 @@ pushd base && npx [email protected] install --lockfile-only && mv pnpm-lock.yaml ../v61

# pnpm v9.0.0 bumped the lockfile version to 9.0
pushd base && npx pnpm@^9.0 install --lockfile-only && mv pnpm-lock.yaml ../v90 && popd

# pnpm v10
pushd base && npx pnpm@^10.0 install --lockfile-only && mv pnpm-lock.yaml ../v10 && popd
2 changes: 2 additions & 0 deletions e2e/pnpm_lockfiles/update-snapshots.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ bazel run @@//v54:repos
bazel run @@//v60:repos
bazel run @@//v61:repos
bazel run @@//v90:repos
bazel run @@//v10:repos

bazel run --enable_bzlmod=false @@//v54:wksp-repos
bazel run --enable_bzlmod=false @@//v60:wksp-repos
bazel run --enable_bzlmod=false @@//v61:wksp-repos
bazel run --enable_bzlmod=false @@//v90:wksp-repos
bazel run --enable_bzlmod=false @@//v10:wksp-repos
6 changes: 6 additions & 0 deletions e2e/pnpm_lockfiles/v10/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
load("@lock-v10//:defs.bzl", "npm_link_all_packages")
load("//:lockfile-test.bzl", "lockfile_test")

npm_link_all_packages()

lockfile_test()
1 change: 1 addition & 0 deletions e2e/pnpm_lockfiles/v10/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../base/package.json
1 change: 1 addition & 0 deletions e2e/pnpm_lockfiles/v10/patches
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../base/patches
Loading
Loading