Skip to content

fix: ensure nextjs picks up the correct config file when called by nextjs_standalone_build() #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbedard merged 5 commits into from
Mar 31, 2026
Merged

fix: ensure nextjs picks up the correct config file when called by nextjs_standalone_build() #2778

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c4cf30d
Fix for Zipline issue
MatrixFrog Mar 19, 2026
a82fff9
fixup and tests
jbedard Mar 31, 2026
f7b6c6d
Merge branch 'main' of github.com:aspect-build/rules_js into tyler/ne…
jbedard Mar 31, 2026
3529084
docs update
jbedard Mar 31, 2026
660930e
docs update
jbedard Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions contrib/nextjs/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,9 +292,17 @@ def nextjs_standalone_build(name, config, srcs, next_js_binary, data = [], **kwa
**kwargs: Other attributes passed to all targets such as `tags`, env
"""

copy_file(
name = "_%s.original_config_file" % name,
src = config,
out = "__original.%s" % config,
visibility = ["//visibility:private"],
tags = ["manual"],
)

# Wrap the config file to add necessary bazel logic
env = kwargs.pop("env", {})
env["NEXTJS_STANDALONE_CONFIG"] = "$(locations %s)" % config
env["NEXTJS_STANDALONE_CONFIG"] = "$(locations _%s.original_config_file)" % name
copy_file(
name = "_%s.standalone_config_file" % name,
src = _next_standalone_config,
Expand All @@ -309,7 +317,10 @@ def nextjs_standalone_build(name, config, srcs, next_js_binary, data = [], **kwa
tool = next_js_binary,
env = env,
args = ["build"],
srcs = srcs + data + [":_%s.standalone_config_file" % name, config],
srcs = srcs + data + [
":_%s.standalone_config_file" % name,
"_%s.original_config_file" % name,
],
out_dirs = [_next_build_out],
chdir = native.package_name(),
mnemonic = "NextJs",
Expand Down
Loading