refactor!: remove unstable_configure_command, remove unstable_ prefix from annotate_packages#1357
refactor!: remove unstable_configure_command, remove unstable_ prefix from annotate_packages#1357jbedard wants to merge 1 commit into
Conversation
✨ Aspect Workflows Tasks📅 Mon Jul 20 08:42:14 UTC 2026 ✅ 40 successful tasks
⏱ Last updated Mon Jul 20 08:46:41 UTC 2026 · 📊 GitHub API quota 443/15,000 (3% used, resets in 55m) |
|
@tamird can confirm if you are using these? |
py_binary startup benchmark
sys.path quality
Bazel analysis benchmark
Auxiliary metrics
|
|
OpenAI does not use |
tamird
left a comment
There was a problem hiding this comment.
The API cleanup is fine for OpenAI, but this removes the only coverage for a still-live and documented custom-BUILD/pre-build-patch path. Please either retain a focused repository-rule regression or remove that unreachable machinery and its documented contract together.
| hub_name = "custom_complete_invalid_overrides", | ||
| lock = "//:uv.lock", | ||
| pyproject = "//:pyproject.toml", | ||
| # sdist_build reparses command strings from its generated repository. |
There was a problem hiding this comment.
This deletes the only complete-custom-BUILD fixture that proves pre-build patch context reaches configure_command and that resource_set, env, monitor_memory, and toolchains are rejected when build_file_content bypasses the generated wheel rule. The sdist_build branch and the documented constraints remain live, and #1347 extends this exact fixture/contract for explicit-empty console scripts. Could we retain or move a focused repository-rule regression, or remove the now-unreachable custom-content machinery/docs consistently?
There was a problem hiding this comment.
The code deletion now looks consistent. Two obsolete build_file_content passages remain in docs/uv-patching.md: the monitoring paragraph around lines 183-186 and the constraints bullet around lines 220-224 that still promises pre_build_patches in the configure context. Please delete both.
|
I traced reachability further: after removing |
… rom annotate_packages
Changes are visible to end-users: yes
BREAKING: remove unstable_configure_command, remove unstable_ prefix from annotate_packages
Test plan