Skip to content

Make script parameter optional in py_console_script_binary#893

Open
hofbi wants to merge 1 commit intoaspect-build:mainfrom
hofbi:patch-1
Open

Make script parameter optional in py_console_script_binary#893
hofbi wants to merge 1 commit intoaspect-build:mainfrom
hofbi:patch-1

Conversation

@hofbi
Copy link
Contributor

@hofbi hofbi commented Mar 24, 2026

Match what rules_python is doing in https://github.com/bazel-contrib/rules_python/blob/d0b9baadc43eff92b3b9df0a04343e7ca653c44a/python/private/py_console_script_binary.bzl#L68-L69


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes/no
  • Breaking change (forces users to change their own code or config): yes/no
  • Suggested release notes appear below: yes/no

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

@aspect-workflows
Copy link

aspect-workflows bot commented Mar 24, 2026

Bazel 8 (Test)

All tests were cache hits

107 tests (100.0%) were fully cached saving 47s.


Bazel 9 (Test)

All tests were cache hits

107 tests (100.0%) were fully cached saving 1m 16s.


Bazel 8 (Test)

e2e

All tests were cache hits

45 tests (100.0%) were fully cached saving 55s.


Bazel 9 (Test)

e2e

All tests were cache hits

45 tests (100.0%) were fully cached saving 54s.


Bazel 8 (Test)

examples/uv_pip_compile

All tests were cache hits

1 test (100.0%) was fully cached saving 444ms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant