fix: support rollup targets in external repositories
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
approved these changes
Mar 13, 2025
devversion
force-pushed
the
fix-external-bundling
branch
from
ae80b36 to
711a8ef
Compare
Currently some paths, passed via command line arguments do not work when
the rollup bundling action is running with inputs from external repos.
See:
```
[!] RollupError: Could not resolve entry module "../rules_angular/worker/index.mjs".
at getRollupError (/usr/local/google/home/pgschwendtner/.cache/bazel/_bazel_pgschwendtner/b3e2b6cb76f4b71f1143108e3588676f/sandbox/linux-sandbox/177/execroot/angular_material/bazel-out/k8-opt-exec-2B5CBBC6/bin/external/rules_angular/worker/_bundle_rollup_binary_/_bundle_rollup_binary.runfiles/rules_angular/node_modules/.aspect_rules_js/[email protected]/node_modules/rollup/dist/shared/parseAst.js:285:41)
at Object.error (/usr/local/google/home/pgschwendtner/.cache/bazel/_bazel_pgschwendtner/b3e2b6cb76f4b71f1143108e3588676f/sandbox/linux-sandbox/177/execroot/angular_material/bazel-out/k8-opt-exec-2B5CBBC6/bin/external/rules_angular/worker/_bundle_rollup_binary_/_bundle_rollup_binary.runfiles/rules_angular/node_modules/.aspect_rules_js/[email protected]/node_modules/rollup/dist/shared/parseAst.js:281:42)
at ModuleLoader.loadEntryModule (/usr/local/google/home/pgschwendtner/.cache/bazel/_bazel_pgschwendtner/b3e2b6cb76f4b71f1143108e3588676f/sandbox/linux-sandbox/177/execroot/angular_material/bazel-out/k8-opt-exec-2B5CBBC6/bin/external/rules_angular/worker/_bundle_rollup_binary_/_bundle_rollup_binary.runfiles/rules_angular/node_modules/.aspect_rules_js/[email protected]/node_modules/rollup/dist/shared/rollup.js:21271:32)
at async Promise.all (index 0)
```
This commit fixes this as `short_path` seems to be not
appropriate/best-practice when passing paths to `js_binary` actions that
clearly run in the `bazel-bin` where `../external` does not exist.
devversion
force-pushed
the
fix-external-bundling
branch
from
711a8ef to
234a194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some paths, passed via command line arguments do not work when the rollup bundling action is running with inputs from external repos.
See:
This commit fixes this as
short_pathseems to be not appropriate/best-practice when passing paths tojs_binaryactions that clearly run in thebazel-binwhere../externaldoes not exist.