Feature/sns producer message attributes#48
Conversation
|
@massa-man Thank you for opening a PR and making the effort. We'll review it in the following days |
YanivD
left a comment
There was a problem hiding this comment.
Thanks again for your contribution!
Please implement few changes before we'll be able to merge and publish it:
- This feature should be added also for
sqs-producer. - Please document this feature in README file.
- WDYT move
snsMessageAttributesprop inside anoptionsobject? In order to make it easy in the future to add new options.
🙏
|
Thanks for the comments. Happy to implement the changes proposed. As for your point 1 (add to https://docs.aws.amazon.com/sns/latest/dg/sns-message-attributes.html |
|
@massa-man thanks for pointing the difference between SNS message attributes and SQS message attributes. |
PR for issue #46