Import support for IIS Express - #17
Draft
Kralizek wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
I'd like to add the possibility to choose if the X86 or X64 edition should be used. Option 1: boolean field that selects 32/64 bits public static IResourceBuilder<IISExpressResource> AddIISExpress(this IDistributedApplicationBuilder builder, string name, string applicationPath, bool use64Bits = true)Option 2: similar but with an enum public static IResourceBuilder<IISExpressResource> AddIISExpress(this IDistributedApplicationBuilder builder, string name, string applicationPath, IISExpressArch arch = IISExpressArch.X64)
public enum IISExpressArch { X64, X86 }Option 3: take in a string with the executable path and provide the Program Files X64 and X86 as static properties that can be used. public static readonly string ProgramFilesX64 => Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ProgramFiles), "IIS Express", "iisexpress.exe");
public static readonly string ProgramFilesX86 => Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ProgramFilesX86), "IIS Express", "iisexpress.exe");
public static IResourceBuilder<IISExpressResource> AddIISExpress(this IDistributedApplicationBuilder builder, string name, string applicationPath, string? iisExpressPath = null)
{
...
iisExpressPath ?= ProgramFilesX64;
...
}
public static IResourceBuilder<IISExpressResource> Use32Bits(this IResourceBuilder<IISExpressResource> builder)
{
// ...
}So I have no idea what's the preferred course of action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing IIS Express resource from this discussion in the Aspire repo: microsoft/aspire#4383 (comment)