Skip to content

Allow user to enter volume name if default volume name is not found - #26

Open
omniopal wants to merge 1 commit into
assafdori:mainfrom
omniopal:patch-2
Open

Allow user to enter volume name if default volume name is not found#26
omniopal wants to merge 1 commit into
assafdori:mainfrom
omniopal:patch-2

Conversation

@omniopal

Copy link
Copy Markdown

Note

Fixes issue #1

If a user runs bypass-mdm.sh with a volume not named as Macintosh HD it will fail with No such file or directory errors because it can't find the volume.

These changes allow the user to enter their own custom volume name if Macintosh HD is not found. This prevents users from having to reformat and rename to Macintosh HD for this script to work.

I tested this on my end with my volume named APPLE SSD and it worked.

@omniopal omniopal mentioned this pull request Dec 19, 2024
@assafdori

Copy link
Copy Markdown
Owner

Looks good, I'll test and merge soon.

@tcler

tcler commented Jan 16, 2025

Copy link
Copy Markdown

I just solved a similar problem in this patch, it will automatically discovering data Volume and root Volume:

dbff514?w=1

Now it works fine on my friend's M1-pro laptop.

BTW: Thanks @assafdori for your great Job! It saved my friend's second-hand Apple laptop

@assafdori assafdori self-assigned this Apr 3, 2025
@Neustradamus

Copy link
Copy Markdown

Dear @assafdori,

Any progress on this PR?

@blalatef

Copy link
Copy Markdown

what happend if i update the mac os after mdm bypass

@mateussiqueira

Copy link
Copy Markdown

Revisão do PR #26 — Custom volume name

@omniopal, boa melhoria de usabilidade. O script original assumia "Macintosh HD" como nome fixo, o que quebrava para qualquer instalação com nome diferente (ex: "APPLE SSD", "MacOS", etc.).

Acertos:

  • ✅ Fallback para o usuário digitar o nome se "Macintosh HD" não existir
  • ✅ Já tem um APPROVED review do HarshVithlani
  • ✅ Código limpo e direto (+35/-13)

Sugestão: Para alinhar com o v3 (#170), considerar portar essa mesma lógica de detecção flexível para o novo script.

Veredito: ✅ Mergeável, deve ser aceito.

@mateussiqueira

Copy link
Copy Markdown

Good UX improvement. The hardcoded "Macintosh HD" assumption breaks for anyone who renamed their volume (which is pretty common). Gives users a chance to type the right name instead of forcing a reformat. Already has an approval. Should merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants