Allow user to enter volume name if default volume name is not found - #26
Allow user to enter volume name if default volume name is not found#26omniopal wants to merge 1 commit into
Conversation
|
Looks good, I'll test and merge soon. |
|
I just solved a similar problem in this patch, it will automatically discovering data Volume and root Volume: Now it works fine on my friend's M1-pro laptop. BTW: Thanks @assafdori for your great Job! It saved my friend's second-hand Apple laptop |
|
Dear @assafdori, Any progress on this PR? |
|
what happend if i update the mac os after mdm bypass |
Revisão do PR #26 — Custom volume name@omniopal, boa melhoria de usabilidade. O script original assumia "Macintosh HD" como nome fixo, o que quebrava para qualquer instalação com nome diferente (ex: "APPLE SSD", "MacOS", etc.). Acertos:
Sugestão: Para alinhar com o v3 (#170), considerar portar essa mesma lógica de detecção flexível para o novo script. Veredito: ✅ Mergeável, deve ser aceito. |
|
Good UX improvement. The hardcoded "Macintosh HD" assumption breaks for anyone who renamed their volume (which is pretty common). Gives users a chance to type the right name instead of forcing a reformat. Already has an approval. Should merge. |
Note
Fixes issue #1
If a user runs
bypass-mdm.shwith a volume not named asMacintosh HDit will fail withNo such file or directoryerrors because it can't find the volume.These changes allow the user to enter their own custom volume name if
Macintosh HDis not found. This prevents users from having to reformat and rename toMacintosh HDfor this script to work.I tested this on my end with my volume named
APPLE SSDand it worked.