Open
Conversation
rzr
added a commit
to CrossStream/astarte-device-sdk-rust
that referenced
this pull request
Jan 15, 2022
My distro RUST setup is not running it out of the box so I used a more recent one. For the record the observed error was: error[E0599]: no variant or associated item named `OutOfMemory` found for enum `ErrorKind` in the current scope -> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/sqlx-core-0.5.10/src/sqlite/connection/establish.rs:107:32 Forwarded: astarte-platform#31 Relate-to: astarte-platform#20 Signed-off-by: Philippe Coval <philippe.coval@astrolabe.coop>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
10b96cc to
de26f19
Compare
Contributor
For development you should consider using rustup instead of the distribution's packaged compiler, as recommended by the rust project Also, the docker build should be added to the CI if we want to support this |
Contributor
Author
|
ok I thought about this too |
rzr
added a commit
to CrossStream/astarte-device-sdk-rust
that referenced
this pull request
Jan 18, 2022
Using officla rust's docker image as base. For the record it can be rebased on ubuntu:21.10 (and cargo should be added to base packages) My distro RUST setup is not running it out of the box so I used a more recent one. For the record the observed error was: error[E0599]: no variant or associated item named `OutOfMemory` found for enum `ErrorKind` in the current scope -> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/sqlx-core-0.5.10/src/sqlite/connection/establish.rs:107:32 Forwarded: astarte-platform#31 Relate-to: astarte-platform#20 Signed-off-by: Philippe Coval <philippe.coval@astrolabe.coop>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
de26f19 to
7d44d79
Compare
Contributor
Author
|
"the docker build should be added to the CI if we want to support this" this can be done in next patch using github actions ? |
shikoku1
reviewed
Jan 24, 2022
Dockerfile
Outdated
Comment on lines
+37
to
+38
| && cargo install --path . \ | ||
| || cargo install --examples --path . \ |
Contributor
Author
There was a problem hiding this comment.
yes it's needed I have updated the commit message
shikoku1
reviewed
Jan 24, 2022
Dockerfile
Outdated
|
|
||
| WORKDIR "${workdir}" | ||
| ENTRYPOINT [ "cargo" ] | ||
| CMD [ "run", "--example", "simple", "--help" ] |
Contributor
There was a problem hiding this comment.
I'm not sure what the expected usage is, feel free to add instructions into the readme
Contributor
Author
There was a problem hiding this comment.
this is the default run command , it could be overridden when using docker run ...
Contributor
There was a problem hiding this comment.
Yeah but now it's calling --help for cargo, overriding --example, it doesn't do anything as it is. I can get what the idea was but I think we should fix this and document the intended usage anyway, because a dockerfile can be use in different ways (for example to produce binaries in a volume)
Contributor
Author
There was a problem hiding this comment.
--help for example will be displayed not cargo
shikoku1
reviewed
Jan 24, 2022
Dockerfile
Outdated
| @@ -0,0 +1,43 @@ | |||
| #!/bin/echo docker build . -f | |||
| # -*- coding: utf-8 -*- | |||
| # SPDX-License-Identifier: MPL-2.0 | |||
Contributor
There was a problem hiding this comment.
The rest of the project is licensed under Apache 2.0, is it ok to have a single file under a different license?
CC: @bettio
rzr
added a commit
to CrossStream/astarte-device-sdk-rust
that referenced
this pull request
Jan 24, 2022
Using official rust's docker image as base. For the record it can be rebased on ubuntu:21.10 (and cargo should be added to base packages) My distro RUST setup is not running it out of the box so I used a more recent one. For the record the observed error was: error[E0599]: no variant or associated item named `OutOfMemory` found for enum `ErrorKind` in the current scope -> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/sqlx-core-0.5.10/src/sqlite/connection/establish.rs:107:32 Install example is needed because there is no default installation rule: error: there is nothing to install in `astarte_sdk v0.1.0 (/local/src/astarte-device-sdk-rust)`, because it has no binaries Forwarded: astarte-platform#31 Relate-to: astarte-platform#20 Signed-off-by: Philippe Coval <philippe.coval@astrolabe.coop>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
7d44d79 to
c7a87d9
Compare
rzr
added a commit
to CrossStream/astarte-device-sdk-rust
that referenced
this pull request
Feb 28, 2022
Using official rust's docker image as base.
Usage is straight forward:
```
docker run astarte-device-sdk-rust:latest run --example simple -- \
--credentials-secret $credentialssecret \
--device-id $deviceid \
--pairing-url $pairingurl \
--realm $realm
```
For the record it can be rebased on ubuntu:21.10
(and cargo should be added to base packages)
My distro RUST setup is not running it out of the box
so I used a more recent one.
For the record the observed error was:
error[E0599]: no variant or associated item named `OutOfMemory` found for enum `ErrorKind` in the current scope
-> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/sqlx-core-0.5.10/src/sqlite/connection/establish.rs:107:32
Install example is needed because there is no default installation rule:
error: there is nothing to install in `astarte_sdk v0.1.0 (/local/src/astarte-device-sdk-rust)`, because it has no binaries
Forwarded: astarte-platform#31
Relate-to: astarte-platform#20
Signed-off-by: Philippe Coval <philippe.coval@astrolabe.coop>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
c7a87d9 to
2b09b12
Compare
Using official rust's docker image as base.
Usage is straight forward:
```
docker run astarte-device-sdk-rust:latest run --example simple -- \
--credentials-secret $credentialssecret \
--device-id $deviceid \
--pairing-url $pairingurl \
--realm $realm
```
For the record it can be rebased on ubuntu:21.10
(and cargo should be added to base packages)
My distro RUST setup is not running it out of the box
so I used a more recent one.
For the record the observed error was:
error[E0599]: no variant or associated item named `OutOfMemory` found for enum `ErrorKind` in the current scope
-> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/sqlx-core-0.5.10/src/sqlite/connection/establish.rs:107:32
Install example is needed because there is no default installation rule:
error: there is nothing to install in `astarte_sdk v0.1.0 (/local/src/astarte-device-sdk-rust)`, because it has no binaries
Forwarded: astarte-platform#31
Relate-to: astarte-platform#20
Signed-off-by: Philippe Coval <philippe.coval@astrolabe.coop>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
2b09b12 to
c184760
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My distro RUST setup is not running it out of the box
so I used a more recent one.
For the record here is is the observed error:
error[E0599]: no variant or associated item named
OutOfMemoryfound for enumErrorKindin the current scope-> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/sqlx-core-0.5.10/src/sqlite/connection/establish.rs:107:32
Relate-to: #20
Signed-off-by: Philippe Coval philippe.coval@astrolabe.coop