Skip to content

chore(docs): add message hub client example#416

Merged
harlem88 merged 3 commits intoastarte-platform:masterfrom
joshuachp:push-mnmuvxlmynxk
Apr 7, 2025
Merged

chore(docs): add message hub client example#416
harlem88 merged 3 commits intoastarte-platform:masterfrom
joshuachp:push-mnmuvxlmynxk

Conversation

@joshuachp
Copy link
Copy Markdown
Collaborator

Show how to connect a client to the MessageHub to send and receive data.

@joshuachp joshuachp marked this pull request as draft February 24, 2025 17:03
@joshuachp joshuachp force-pushed the push-mnmuvxlmynxk branch 4 times, most recently from 5ca6930 to a82d40b Compare February 25, 2025 16:10
@joshuachp joshuachp changed the title [WIP]: chore(docs): add message hub client example chore(docs): add message hub client example Feb 25, 2025
@joshuachp joshuachp requested a review from harlem88 February 25, 2025 16:11
@joshuachp joshuachp force-pushed the push-mnmuvxlmynxk branch 2 times, most recently from 469d24d to d9413f3 Compare February 25, 2025 16:48
@joshuachp joshuachp marked this pull request as ready for review February 25, 2025 16:48
@joshuachp joshuachp force-pushed the push-mnmuvxlmynxk branch 4 times, most recently from fa30769 to 7b1bd5d Compare March 3, 2025 09:18
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.6%. Comparing base (641399f) to head (9334554).
Report is 4 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
src/client.rs 58.3% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harlem88 harlem88 requested a review from lucaato March 3, 2025 15:59
@joshuachp joshuachp force-pushed the push-mnmuvxlmynxk branch from 7b1bd5d to dfcd22c Compare March 3, 2025 16:49
@joshuachp joshuachp requested a review from harlem88 March 3, 2025 16:49
@harlem88 harlem88 requested a review from rgallor March 4, 2025 08:59
Copy link
Copy Markdown
Contributor

@rgallor rgallor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments I've left, I think we should call all the examples using the same convention: up to now we have used examples with non-abbreviated names separated by an underscore, therefore I'd opt to use examples/message_hub_client as the example name. Nevertheless, I would prefer using score-separated names (rather than using the underscore). Maybe we can talk about it separately.

@joshuachp joshuachp force-pushed the push-mnmuvxlmynxk branch 3 times, most recently from e12124b to f0bbabe Compare March 4, 2025 11:15
@joshuachp joshuachp requested a review from rgallor March 4, 2025 11:16
@joshuachp
Copy link
Copy Markdown
Collaborator Author

Apart from the comments I've left, I think we should call all the examples using the same convention: up to now we have used examples with non-abbreviated names separated by an underscore, therefore I'd opt to use examples/message_hub_client as the example name. Nevertheless, I would prefer using score-separated names (rather than using the underscore). Maybe we can talk about it separately.

I changed to use underscores in the example directory and name.

@joshuachp joshuachp force-pushed the push-mnmuvxlmynxk branch 2 times, most recently from 97a293b to 36b9221 Compare March 4, 2025 11:38
@joshuachp joshuachp force-pushed the push-mnmuvxlmynxk branch from 36b9221 to 404eefd Compare March 5, 2025 14:17
@joshuachp joshuachp requested a review from lucaato March 5, 2025 14:17
@joshuachp joshuachp force-pushed the push-mnmuvxlmynxk branch 11 times, most recently from b00d2e0 to 4b1e759 Compare April 3, 2025 10:40
@joshuachp joshuachp force-pushed the push-mnmuvxlmynxk branch 2 times, most recently from 3a74f87 to 73df7ce Compare April 3, 2025 15:29
@joshuachp joshuachp force-pushed the push-mnmuvxlmynxk branch 3 times, most recently from 020e034 to 286390c Compare April 7, 2025 08:11
Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
Show how to connect a client to the MessageHub to send and receive
data.

Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
Add the required features for each example.

Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
@joshuachp joshuachp force-pushed the push-mnmuvxlmynxk branch from 286390c to 9334554 Compare April 7, 2025 10:20
@harlem88 harlem88 merged commit c2ee721 into astarte-platform:master Apr 7, 2025
18 checks passed
@joshuachp joshuachp deleted the push-mnmuvxlmynxk branch April 7, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants