chore(rustup): add rust-toolchain.toml config#438
Merged
harlem88 merged 2 commits intoastarte-platform:masterfrom Apr 4, 2025
Merged
chore(rustup): add rust-toolchain.toml config#438harlem88 merged 2 commits intoastarte-platform:masterfrom
harlem88 merged 2 commits intoastarte-platform:masterfrom
Conversation
joshuachp
force-pushed
the
chore/rust-toolchain
branch
3 times, most recently
from
baa7e59 to
e8fbab8
Compare
joshuachp
force-pushed
the
chore/rust-toolchain
branch
2 times, most recently
from
0018833 to
3ce9b76
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files🚀 New features to boost your workflow:
|
lucaato
reviewed
Apr 3, 2025
Contributor
lucaato
left a comment
lucaato
left a comment
There was a problem hiding this comment.
A part from a comment LGTM. Maybe we could schedule a job to run on master every n days to check the build for newer version. If we want something to push us to update the toolchain version in the toml.
joshuachp
force-pushed
the
chore/rust-toolchain
branch
from
3ce9b76 to
f11a00c
Compare
harlem88
reviewed
Apr 3, 2025
joshuachp
force-pushed
the
chore/rust-toolchain
branch
2 times, most recently
from
fb01059 to
7eabc54
Compare
harlem88
approved these changes
Apr 3, 2025
Specify the latest compatible toolchain in the rust-toolchain.toml file. This will give better stability in local development and CI, without random breakages and new warning to solve. Currently we use the beta channel for an issue in rust-analyzer on 1.85.1, where diagnostics are cleared. But we should move to the stable channel on next release. Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
Use the https://github.com/actions-rust-lang/setup-rust-toolchain action to install the rust toolchain from file. Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
joshuachp
force-pushed
the
chore/rust-toolchain
branch
from
7eabc54 to
6ac7fc5
Compare
lucaato
approved these changes
Apr 4, 2025
rgallor
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify the latest compatible toolchain in the rust-toolchain.toml file. This will give better stability in local development and CI, without random breakages and new warning to solve.
Currently we use the beta channel for an issue in rust-analyzer on 1.85.1, where diagnostics are cleared. But we should move to the stable channel on next release.