feat(capabilities): Add capabilites message type#1049
Closed
lusergit wants to merge 3 commits intoastarte-platform:masterfrom
Closed
feat(capabilities): Add capabilites message type#1049lusergit wants to merge 3 commits intoastarte-platform:masterfrom
lusergit wants to merge 3 commits intoastarte-platform:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
- Coverage 69.23% 69.14% -0.10%
==========================================
Files 275 275
Lines 7193 7246 +53
==========================================
+ Hits 4980 5010 +30
- Misses 2213 2236 +23 ☔ View full report in Codecov by Sentry. |
lusergit
force-pushed
the
feat/capabilities
branch
2 times, most recently
from
72bd511 to
92cf9b8
Compare
lusergit
changed the title
lusergit
changed the title
lusergit
force-pushed
the
feat/capabilities
branch
6 times, most recently
from
41e59ce to
944f37b
Compare
Collaborator
Author
|
astarte-platform/astarte_core#115 got merged, the last commit also bumps up astarte_core to the last version |
lusergit
force-pushed
the
feat/capabilities
branch
from
944f37b to
9517676
Compare
Annopaolo
requested changes
Jan 27, 2025
Collaborator
Annopaolo
left a comment
Annopaolo
left a comment
There was a problem hiding this comment.
The general approach is good! There are however some minor details to iterate on
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/impl.ex
Outdated
Show resolved
Hide resolved
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/impl.ex
Outdated
Show resolved
Hide resolved
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/impl.ex
Outdated
Show resolved
Hide resolved
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/impl.ex
Outdated
Show resolved
Hide resolved
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/queries.ex
Outdated
Show resolved
Hide resolved
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/queries.ex
Outdated
Show resolved
Hide resolved
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/impl.ex
Outdated
Show resolved
Hide resolved
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/impl.ex
Outdated
Show resolved
Hide resolved
lusergit
force-pushed
the
feat/capabilities
branch
3 times, most recently
from
b57f1c9 to
cd7ff67
Compare
lusergit
changed the title
lusergit
force-pushed
the
feat/capabilities
branch
2 times, most recently
from
5d6ed5d to
790a9f7
Compare
lusergit
changed the title
lusergit
force-pushed
the
feat/capabilities
branch
from
790a9f7 to
9956f35
Compare
lusergit
changed the title
Annopaolo
requested changes
Jan 29, 2025
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/impl.ex
Outdated
Show resolved
Hide resolved
lusergit
force-pushed
the
feat/capabilities
branch
4 times, most recently
from
9e6bd84 to
8517951
Compare
lusergit
force-pushed
the
feat/capabilities
branch
from
8517951 to
ac96444
Compare
Annopaolo
requested changes
Feb 4, 2025
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/impl.ex
Outdated
Show resolved
Hide resolved
lusergit
force-pushed
the
feat/capabilities
branch
3 times, most recently
from
ced1b0f to
83e0e2e
Compare
sorru94
reviewed
Feb 17, 2025
lusergit
force-pushed
the
feat/capabilities
branch
2 times, most recently
from
dcdfbb4 to
5422d84
Compare
- Devices can publish on `capabilities` endpoint - Adds the `purge_properties_compression_format` capability, setting whether the device should recive the purge properties compressed with zlib or in plain text Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>
- Device capabilities subsection in the Astarte MQTT v1 protocol specification - Mention of device capabilities in the *connect device* section Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>
Update astarte core to support `Astarte.Core.Capabilities` Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>
lusergit
force-pushed
the
feat/capabilities
branch
from
5422d84 to
0ac1b2c
Compare
Collaborator
|
Closing the PR was a mistake 🥲. Reopen it! |
Collaborator
|
Superseded by #1452 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devices can declare to astarte how they will handle future communications by publishing their capabilities on
/<realm>/<device_id>/capabilitiesendpoint. This PR adds both a basic structure for capabilities handling and one capability:purge_properties_compression_format.Capabilities structure
capabilitiestopic astarte_vmq_plugin#98 devices can publish on/<realm>/<device_id>/capabilitiesmessages concerning capabilities. Such messages are handled in DUP as a new "capabilities" message type.devicestable in the database, hence a new migration in astarte house keeping has been added (see0006_devices_add_purge_properties_compression_format).Purge properties compression format
Together with the capabilities structure the
purge_properties_compression_formatcapability have been introduced (see astarte-platform/astarte_core#115). The capability states how astarte should send the purge properties message: if compressed withzlibor in plaintext. The default value for the capability iszlib, which has been chosen for backward compatibility.