fix(dup): last_connection / last_disconnection timestamp unit#1134
Merged
Annopaolo merged 1 commit intoastarte-platform:release-1.2from Mar 13, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #1134 +/- ##
===============================================
+ Coverage 63.21% 63.24% +0.03%
===============================================
Files 41 41
Lines 1968 1970 +2
===============================================
+ Hits 1244 1246 +2
Misses 724 724 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
noaccOS
requested review from
Annopaolo,
davidebriani,
eddbbt and
lusergit
and removed request for
Annopaolo and
davidebriani
eddbbt
approved these changes
Mar 11, 2025
davidebriani
requested changes
Mar 11, 2025
Comment on lines
+971
to
+974
| defp pad_usec(datetime) do | ||
| # Ecto requires :utc_datetime_usec to be in microsecond precision | ||
| microsecond = | ||
| case datetime.microsecond do | ||
| {_, 0} -> {0, 6} | ||
| {n, _} -> {n, 6} | ||
| end | ||
|
|
||
| %{datetime | microsecond: microsecond} | ||
| end |
Collaborator
There was a problem hiding this comment.
Just Ecto.Type.cast!(:utc_datetime_usec, datetime) should work.
I think the only issue is where the code is preparing database changes with Ecto.Changeset.change which doesn't automatically cast params according to their Ecto types.
Collaborator
Author
There was a problem hiding this comment.
If you don't like the case, I was experimenting and it looks like DateTime.add(datetime, 0, :microsecond) also sets the precision to 6
Collaborator
Author
There was a problem hiding this comment.
I've changed it to DateTime.add(datetime, 0, :microsecond)
noaccOS
force-pushed
the
fix/connection-unit
branch
from
5403d94 to
8178378
Compare
Annopaolo
approved these changes
Mar 12, 2025
noaccOS
force-pushed
the
fix/connection-unit
branch
from
8178378 to
b82c32d
Compare
davidebriani
approved these changes
Mar 12, 2025
5 tasks
timestamps were in millisecond precision, but `DateTime.from_unix!` was given microsecond precision. This caused datetimes to be incorrect. this was the result after setting up astarte in 5 minutes and running astarte-stream-qt5-test ``` ❯ docker compose exec -it scylla cqlsh -e 'select last_connection from test.devices;' last_connection --------------------------------- 1970-01-21 03:48:22.216000+0000 ``` Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
noaccOS
force-pushed
the
fix/connection-unit
branch
from
b82c32d to
042574f
Compare
Annopaolo
approved these changes
Mar 13, 2025
5 tasks
AliouneGaye21
pushed a commit
to AliouneGaye21/astarte
that referenced
this pull request
Sep 22, 2025
As per astarte PR astarte-platform#1134 Signed-off-by: Eddy Babetto <eddy.babetto@secomind.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a regression was introduced in 2c66918, where timestamps were in millisecond precision, but
DateTime.from_unix!was given microsecond precision. This caused datetimes to be incorrect.this was the result after setting up astarte in 5 minutes and running astarte-stream-qt5-test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g. usage docs, diagrams, etc.: