refactor: adapt database structure for openbao#1873
refactor: adapt database structure for openbao#1873noaccOS wants to merge 1 commit intoastarte-platform:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1873 +/- ##
==========================================
- Coverage 83.82% 83.81% -0.01%
==========================================
Files 572 572
Lines 10040 10040
==========================================
- Hits 8416 8415 -1
- Misses 1624 1625 +1
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| field :voucher_data, :binary | ||
| field :user_id, :binary | ||
| field :key_name, :string | ||
| field :replacement_guid, :binary | ||
| field :replacement_rv_info, CBOREncoded, using: RendezvousInfo | ||
| field :replacement_pub_key, CBOREncoded, using: PublicKey |
There was a problem hiding this comment.
following irl discussion, we agreed that an optional "key_description" field would reasonable to have, in order to being able to differentiante without using super long key names. Not sure where to put it since we're not saving anything key related
There was a problem hiding this comment.
I'm afraid openbao does not allow adding descriptions to the keys, and I don't think it's worth going through the trouble of having a local cache of the keys just to be able to add a description
a64b13a to
d868b86
Compare
There was a problem hiding this comment.
Could it make sense to add also a field for the 'key_type'? It may ease some TO2 internal lookups
There was a problem hiding this comment.
imo it's easy enough by reading ownershipvoucher.ovheader.ovpubkey.pktype
d868b86 to
3b9355c
Compare
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
3b9355c to
1f5f425
Compare
What this PR does / why we need it:
rework the database in preparation for openbao-based api/to2
Additional documentation e.g. usage docs, diagrams, reviewer notes, etc.:
depends on #1868
Thanks for sending a pull request! If this is your first time, here are some tips for you:
When fixing existing issues, use github's syntax to link your pull request to it
We also have a syntax to signal dependencies to other open pull requests
In case of stacked PRs, you may add the PR number in the last commit's title instead: