refactor(fdo): re-enable credential reuse logic#1909
Closed
AliouneGaye21 wants to merge 0 commit intoastarte-platform:baofrom
Closed
refactor(fdo): re-enable credential reuse logic#1909AliouneGaye21 wants to merge 0 commit intoastarte-platform:baofrom
AliouneGaye21 wants to merge 0 commit intoastarte-platform:baofrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## bao #1909 +/- ##
==========================================
+ Coverage 84.64% 84.68% +0.04%
==========================================
Files 385 394 +9
Lines 8003 8339 +336
==========================================
+ Hits 6774 7062 +288
- Misses 1229 1277 +48
... and 13 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
noaccOS
requested changes
Apr 3, 2026
| def credential_reuse?(session) do | ||
| is_nil(session.replacement_pub_key) and | ||
| is_nil(session.replacement_rv_info) and | ||
| session.replacement_guid == session.guid |
Collaborator
There was a problem hiding this comment.
Suggested change
| session.replacement_guid == session.guid | |
| is_nil(session.replacement_guid) |
except it's not the session, all 3 values are in the ownership voucher entry
Comment on lines
+143
to
+152
| next_guid = session.replacement_guid || guid | ||
| next_rv_info = session.replacement_rv_info || ownership_voucher.header.rendezvous_info | ||
| next_owner_pub_key = session.replacement_pub_key || owner_public_key | ||
|
|
||
| # {:ok, private_key} = COSE.Keys.from_pem(private_key) | ||
|
|
||
| connection_credentials = %{ | ||
| guid: guid, | ||
| rendezvous_info: rendezvous_info, | ||
| owner_pub_key: owner_public_key, | ||
| guid: next_guid, | ||
| rendezvous_info: next_rv_info, | ||
| owner_pub_key: next_owner_pub_key, |
Collaborator
There was a problem hiding this comment.
let's revert this: the session is for that single guid, replacement data is in the ownership_voucher entry instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Additional documentation e.g. usage docs, diagrams, reviewer notes, etc.:
Thanks for sending a pull request! If this is your first time, here are some tips for you:
When fixing existing issues, use github's syntax to link your pull request to it
We also have a syntax to signal dependencies to other open pull requests
In case of stacked PRs, you may add the PR number in the last commit's title instead: