Skip to content

feat: add device deletion started event#126

Merged
noaccOS merged 1 commit intoastarte-platform:release-1.3from
noaccOS:push-rvuroutrrzzq
Sep 25, 2025
Merged

feat: add device deletion started event#126
noaccOS merged 1 commit intoastarte-platform:release-1.3from
noaccOS:push-rvuroutrrzzq

Conversation

@noaccOS
Copy link
Copy Markdown
Collaborator

@noaccOS noaccOS commented Sep 24, 2025

protoc --elixir_out=. --elixir_opt=package_prefix=astarte.core.triggers.simple_events lib/astarte_core/triggers/simple_events/*.proto

the event has been assigned code 21 to leave space to device creation

based on #125

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.54%. Comparing base (3e9e5a8) to head (02bc3ef).
⚠️ Report is 1 commits behind head on release-1.3.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.3     #126   +/-   ##
============================================
  Coverage        79.54%   79.54%           
============================================
  Files               26       26           
  Lines              836      836           
============================================
  Hits               665      665           
  Misses             171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noaccOS noaccOS requested review from a team, AliouneGaye21 and emirh1 and removed request for a team September 24, 2025 13:33
Copy link
Copy Markdown
Collaborator

@lusergit lusergit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

protoc --elixir_out=. --elixir_opt=package_prefix=astarte.core.triggers.simple_events lib/astarte_core/triggers/simple_events/*.proto

the event has been assigned code 21 to leave space to device creation

Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS noaccOS merged commit e9d5a3e into astarte-platform:release-1.3 Sep 25, 2025
3 checks passed
@noaccOS noaccOS deleted the push-rvuroutrrzzq branch September 25, 2025 14:58
noaccOS added a commit to noaccOS/astarte_core that referenced this pull request Sep 25, 2025
astarte-platform#125 astarte-platform#126 astarte-platform#127 added new simple events but their encoders were not
defined, which would mean http triggers wouldn't work.

add tests for the newly added triggers

fix a warning

Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
noaccOS added a commit that referenced this pull request Oct 2, 2025
#125 #126 #127 added new simple events but their encoders were not
defined, which would mean http triggers wouldn't work.

add tests for the newly added triggers

fix a warning

Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
nedimtokic pushed a commit to nedimtokic/astarte_core that referenced this pull request Mar 10, 2026
protoc --elixir_out=. --elixir_opt=package_prefix=astarte.core.triggers.simple_events lib/astarte_core/triggers/simple_events/*.proto

the event has been assigned code 21 to leave space to device creation

Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
nedimtokic pushed a commit to nedimtokic/astarte_core that referenced this pull request Mar 10, 2026
…te-platform#128)

astarte-platform#125 astarte-platform#126 astarte-platform#127 added new simple events but their encoders were not
defined, which would mean http triggers wouldn't work.

add tests for the newly added triggers

fix a warning

Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants