Skip to content

fix: reject interfaces with conflicting options in aggregate mappings (fw-port for release 1.3)#135

Merged
noaccOS merged 4 commits intoastarte-platform:release-1.3from
frossq:fix-1072-1.3
Feb 24, 2026
Merged

fix: reject interfaces with conflicting options in aggregate mappings (fw-port for release 1.3)#135
noaccOS merged 4 commits intoastarte-platform:release-1.3from
frossq:fix-1072-1.3

Conversation

@frossq
Copy link
Copy Markdown
Contributor

@frossq frossq commented Feb 23, 2026

Validate all possible mismatching mapping options in interfaces with object aggregation (e.g. check if a mapping contains a different database_retention_ttl value). Test added. This is needed to fix astarte/#1072.

noaccOS and others added 2 commits August 22, 2025 09:22
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
…astarte-platform#132)

Validate all possible mismatching mapping options in interfaces with object aggregation
(e.g. check if a mapping contains a different database_retention_ttl value). Test added.
This is needed to fix [astarte/#1072](astarte-platform/astarte#1072).
@frossq frossq requested review from a team, AliouneGaye21 and nedimtokic and removed request for a team February 23, 2026 14:20
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.88%. Comparing base (ed0f131) to head (7385079).
⚠️ Report is 5 commits behind head on release-1.3.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.3     #135      +/-   ##
===============================================
+ Coverage        79.71%   79.88%   +0.16%     
===============================================
  Files               26       26              
  Lines              838      840       +2     
===============================================
+ Hits               668      671       +3     
+ Misses             170      169       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frossq frossq requested a review from noaccOS February 23, 2026 14:20
@frossq frossq changed the title fix: reject interfaces with conflicting options in aggregate mappings (for release 1.3) fix: reject interfaces with conflicting options in aggregate mappings (fw-port for release 1.3) Feb 23, 2026
@frossq frossq force-pushed the fix-1072-1.3 branch 2 times, most recently from eb86763 to 5cc79b3 Compare February 24, 2026 10:07
frossq and others added 2 commits February 24, 2026 14:20
Signed-off-by: frossq <francesco.asquini@secomind.com>
Signed-off-by: frossq <francesco.asquini@secomind.com>
@noaccOS noaccOS merged commit 42b92a5 into astarte-platform:release-1.3 Feb 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants