simple_event + test#69
Merged
shinnokdisengir merged 12 commits intoastarte-platform:mainfrom Oct 21, 2025
Merged
Conversation
shinnokdisengir
force-pushed
the
feature/triggers/simple-event
branch
6 times, most recently
from
1493078 to
e4e8532
Compare
eddbbt
approved these changes
Sep 22, 2025
shinnokdisengir
added
the
You shall not pass!
shinnokdisengir
force-pushed
the
feature/triggers/simple-event
branch
2 times, most recently
from
04bb080 to
b10ecba
Compare
noaccOS
requested changes
Sep 30, 2025
lib/astarte/core/generators/triggers/simple_events/interface_added_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/interface_removed_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/interface_minor_updated_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/interface_minor_updated_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/common_data_event.ex
Outdated
Show resolved
Hide resolved
shinnokdisengir
force-pushed
the
feature/triggers/simple-event
branch
from
b10ecba to
5157cc8
Compare
shinnokdisengir
removed
the
You shall not pass!
shinnokdisengir
force-pushed
the
feature/triggers/simple-event
branch
4 times, most recently
from
1d70da3 to
9499f5d
Compare
noaccOS
requested changes
Oct 15, 2025
lib/astarte/core/generators/triggers/simple_events/common_data_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/value_change_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/value_change_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/value_change_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/interface_minor_updated_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/interface_minor_updated_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/incoming_data_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/simple_event.ex
Outdated
Show resolved
Hide resolved
shinnokdisengir
force-pushed
the
feature/triggers/simple-event
branch
2 times, most recently
from
e970c1c to
4c295f5
Compare
shinnokdisengir
force-pushed
the
feature/triggers/simple-event
branch
4 times, most recently
from
1ad0965 to
c235c64
Compare
noaccOS
requested changes
Oct 20, 2025
Collaborator
noaccOS
left a comment
noaccOS
left a comment
There was a problem hiding this comment.
second review ronud
some comments are relative to multiple files (eg all events relative to a generated value) but I only left one for each type as a general comment
lib/astarte/core/generators/triggers/simple_events/interface_added_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/incoming_data_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/interface_added_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/interface_minor_updated_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/simple_event.ex
Outdated
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/value_change_applied_event.ex
Outdated
Show resolved
Hide resolved
shinnokdisengir
force-pushed
the
feature/triggers/simple-event
branch
from
c235c64 to
095d865
Compare
- value generator feature and fixes + test - interface generator endpoint_by_aggregation + test - interface generator minor_version become public Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
shinnokdisengir
force-pushed
the
feature/triggers/simple-event
branch
from
095d865 to
4957ee5
Compare
noaccOS
reviewed
Oct 21, 2025
lib/astarte/core/generators/triggers/simple_events/path_created_event.ex
Show resolved
Hide resolved
lib/astarte/core/generators/triggers/simple_events/simple_event.ex
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
shinnokdisengir
force-pushed
the
feature/triggers/simple-event
branch
from
4957ee5 to
753c502
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
complete triggers events + simple_event wrapper