fix: wrong supervisor behavior#105
Merged
davidebriani merged 1 commit intoastarte-platform:feature/erlang-rpcfrom Apr 9, 2025
Merged
fix: wrong supervisor behavior#105davidebriani merged 1 commit intoastarte-platform:feature/erlang-rpcfrom
davidebriani merged 1 commit intoastarte-platform:feature/erlang-rpcfrom
Conversation
Moves the `case` caluse of the lookup of an existing RPC server to a `with` cluase, effectively starting a new child only if no other children are present in the registry for the `:server` key Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>
davidebriani
approved these changes
Apr 9, 2025
davidebriani
merged commit f2cfe8a
into
astarte-platform:feature/erlang-rpc
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPC supervisor crashed when another rpc serve was already present in the distributed registry. With this PR the RPC server starts if no other server are in the registry and otherwise nothing happens 👍